diff options
author | Russell Keith-Magee <russell@keith-magee.com> | 2011-09-10 00:46:48 +0000 |
---|---|---|
committer | Russell Keith-Magee <russell@keith-magee.com> | 2011-09-10 00:46:48 +0000 |
commit | 33076af6f2aa5285b3a70246e14163b901b512f7 (patch) | |
tree | 736b1ce05cdd0d6a0f368aa54994e28bfe4439d3 /django/contrib/sessions/backends/cache.py | |
parent | 893cea211ae88c6f68a6c2c281890d6f63541286 (diff) | |
download | django-33076af6f2aa5285b3a70246e14163b901b512f7.tar.gz |
Corrected an issue which could allow attackers to manipulate session data using the cache. A security announcement will be made shortly.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16759 bcc190cf-cafb-0310-a4f2-bffc1f526a37
Diffstat (limited to 'django/contrib/sessions/backends/cache.py')
-rw-r--r-- | django/contrib/sessions/backends/cache.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/django/contrib/sessions/backends/cache.py b/django/contrib/sessions/backends/cache.py index 22c95b23d5..41d203e918 100644 --- a/django/contrib/sessions/backends/cache.py +++ b/django/contrib/sessions/backends/cache.py @@ -1,6 +1,8 @@ from django.contrib.sessions.backends.base import SessionBase, CreateError from django.core.cache import cache +KEY_PREFIX = "django.contrib.sessions.cache" + class SessionStore(SessionBase): """ A cache-based session store. @@ -10,7 +12,7 @@ class SessionStore(SessionBase): super(SessionStore, self).__init__(session_key) def load(self): - session_data = self._cache.get(self.session_key) + session_data = self._cache.get(KEY_PREFIX + self.session_key) if session_data is not None: return session_data self.create() @@ -37,18 +39,18 @@ class SessionStore(SessionBase): func = self._cache.add else: func = self._cache.set - result = func(self.session_key, self._get_session(no_load=must_create), + result = func(KEY_PREFIX + self.session_key, self._get_session(no_load=must_create), self.get_expiry_age()) if must_create and not result: raise CreateError def exists(self, session_key): - return session_key in self._cache + return (KEY_PREFIX + session_key) in self._cache def delete(self, session_key=None): if session_key is None: if self._session_key is None: return session_key = self._session_key - self._cache.delete(session_key) + self._cache.delete(KEY_PREFIX + session_key) |