summaryrefslogtreecommitdiff
path: root/django/contrib/staticfiles/storage.py
diff options
context:
space:
mode:
authorAde Lee <alee@redhat.com>2021-08-10 18:13:54 -0400
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2021-10-12 08:58:27 +0200
commitd10c7bfe56f025ccc690721c9f13e7029b777b9c (patch)
tree0f3cab5666f8cd69c99f3b91822e2f28b8dcf609 /django/contrib/staticfiles/storage.py
parentb1b26b37aff0c80d6abdf15c5ffdf0440a9a1d6a (diff)
downloaddjango-d10c7bfe56f025ccc690721c9f13e7029b777b9c.tar.gz
Fixed #28401 -- Allowed hashlib.md5() calls to work with FIPS kernels.
md5 is not an approved algorithm in FIPS mode, and trying to instantiate a hashlib.md5() will fail when the system is running in FIPS mode. md5 is allowed when in a non-security context. There is a plan to add a keyword parameter (usedforsecurity) to hashlib.md5() to annotate whether or not the instance is being used in a security context. In the case where it is not, the instantiation of md5 will be allowed. See https://bugs.python.org/issue9216 for more details. Some downstream python versions already support this parameter. To support these versions, a new encapsulation of md5() has been added. This encapsulation will pass through the usedforsecurity parameter in the case where the parameter is supported, and strip it if it is not. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Diffstat (limited to 'django/contrib/staticfiles/storage.py')
-rw-r--r--django/contrib/staticfiles/storage.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/django/contrib/staticfiles/storage.py b/django/contrib/staticfiles/storage.py
index 7cf43ed6ab..5fa088a29a 100644
--- a/django/contrib/staticfiles/storage.py
+++ b/django/contrib/staticfiles/storage.py
@@ -1,4 +1,3 @@
-import hashlib
import json
import os
import posixpath
@@ -10,6 +9,7 @@ from django.contrib.staticfiles.utils import check_settings, matches_patterns
from django.core.exceptions import ImproperlyConfigured
from django.core.files.base import ContentFile
from django.core.files.storage import FileSystemStorage, get_storage_class
+from django.utils.crypto import md5
from django.utils.functional import LazyObject
@@ -89,10 +89,10 @@ class HashedFilesMixin:
"""
if content is None:
return None
- md5 = hashlib.md5()
+ hasher = md5(usedforsecurity=False)
for chunk in content.chunks():
- md5.update(chunk)
- return md5.hexdigest()[:12]
+ hasher.update(chunk)
+ return hasher.hexdigest()[:12]
def hashed_name(self, name, content=None, filename=None):
# `filename` is the name of file to hash if `content` isn't given.