summaryrefslogtreecommitdiff
path: root/django/db/backends/postgresql/client.py
diff options
context:
space:
mode:
authormieciu <przemyslaw.hejman@gmail.com>2016-06-02 14:03:03 -0700
committerTim Graham <timograham@gmail.com>2016-06-03 12:30:21 -0400
commit19ff506878071ac93de684fe01328707e75e2b3a (patch)
treea8a6d90bc9a807be0e68c2a2f2caf7dea5e8399a /django/db/backends/postgresql/client.py
parent4a4d7f980e2a66756e1e424f7648dcd28ff765b7 (diff)
downloaddjango-19ff506878071ac93de684fe01328707e75e2b3a.tar.gz
Fixed #26698 -- Fixed PostgreSQL dbshell crash on an empty database name.
Diffstat (limited to 'django/db/backends/postgresql/client.py')
-rw-r--r--django/db/backends/postgresql/client.py18
1 files changed, 9 insertions, 9 deletions
diff --git a/django/db/backends/postgresql/client.py b/django/db/backends/postgresql/client.py
index 5e3e288301..1b4b884c60 100644
--- a/django/db/backends/postgresql/client.py
+++ b/django/db/backends/postgresql/client.py
@@ -17,14 +17,14 @@ class DatabaseClient(BaseDatabaseClient):
executable_name = 'psql'
@classmethod
- def runshell_db(cls, settings_dict):
+ def runshell_db(cls, conn_params):
args = [cls.executable_name]
- host = settings_dict.get('HOST', '')
- port = settings_dict.get('PORT', '')
- name = settings_dict.get('NAME', '')
- user = settings_dict.get('USER', '')
- passwd = settings_dict.get('PASSWORD', '')
+ host = conn_params.get('host', '')
+ port = conn_params.get('port', '')
+ dbname = conn_params.get('database', '')
+ user = conn_params.get('user', '')
+ passwd = conn_params.get('password', '')
if user:
args += ['-U', user]
@@ -32,7 +32,7 @@ class DatabaseClient(BaseDatabaseClient):
args += ['-h', host]
if port:
args += ['-p', str(port)]
- args += [name]
+ args += [dbname]
temp_pgpass = None
try:
@@ -43,7 +43,7 @@ class DatabaseClient(BaseDatabaseClient):
print_(
_escape_pgpass(host) or '*',
str(port) or '*',
- _escape_pgpass(name) or '*',
+ _escape_pgpass(dbname) or '*',
_escape_pgpass(user) or '*',
_escape_pgpass(passwd),
file=temp_pgpass,
@@ -63,4 +63,4 @@ class DatabaseClient(BaseDatabaseClient):
del os.environ['PGPASSFILE']
def runshell(self):
- DatabaseClient.runshell_db(self.connection.settings_dict)
+ DatabaseClient.runshell_db(self.connection.get_connection_params())