summaryrefslogtreecommitdiff
path: root/django/db/backends/sqlite3/schema.py
diff options
context:
space:
mode:
authorSimon Charette <charettes@users.noreply.github.com>2018-10-29 05:33:41 -0400
committerCarlton Gibson <carlton.gibson@noumenal.es>2018-10-29 10:33:41 +0100
commit95bda03f2da15172cf342f13ba8a77c007b63fbb (patch)
treeb0889065f27b5916e8f01c06b9c3aa19ef043fe9 /django/db/backends/sqlite3/schema.py
parentf77fc56c9671a2e2498e3920d79e247e6de18c16 (diff)
downloaddjango-95bda03f2da15172cf342f13ba8a77c007b63fbb.tar.gz
Fixed #29868 -- Retained database constraints on SQLite table rebuilds.
Refs #11964. Thanks Scott Stevens for testing this upcoming feature and the report.
Diffstat (limited to 'django/db/backends/sqlite3/schema.py')
-rw-r--r--django/db/backends/sqlite3/schema.py14
1 files changed, 3 insertions, 11 deletions
diff --git a/django/db/backends/sqlite3/schema.py b/django/db/backends/sqlite3/schema.py
index 99382d35ce..7aa1f28f53 100644
--- a/django/db/backends/sqlite3/schema.py
+++ b/django/db/backends/sqlite3/schema.py
@@ -126,8 +126,7 @@ class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):
else:
super().alter_field(model, old_field, new_field, strict=strict)
- def _remake_table(self, model, create_field=None, delete_field=None, alter_field=None,
- add_constraint=None, remove_constraint=None):
+ def _remake_table(self, model, create_field=None, delete_field=None, alter_field=None):
"""
Shortcut to transform a model from old_model into new_model
@@ -224,13 +223,6 @@ class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):
]
constraints = list(model._meta.constraints)
- if add_constraint:
- constraints.append(add_constraint)
- if remove_constraint:
- constraints = [
- constraint for constraint in constraints
- if remove_constraint.name != constraint.name
- ]
# Construct a new model for the new state
meta_contents = {
@@ -383,7 +375,7 @@ class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):
self.delete_model(old_field.remote_field.through)
def add_constraint(self, model, constraint):
- self._remake_table(model, add_constraint=constraint)
+ self._remake_table(model)
def remove_constraint(self, model, constraint):
- self._remake_table(model, remove_constraint=constraint)
+ self._remake_table(model)