summaryrefslogtreecommitdiff
path: root/django/forms/utils.py
diff options
context:
space:
mode:
authorLoic Bistuer <loic.bistuer@gmail.com>2014-03-23 00:16:49 +0700
committerTim Graham <timograham@gmail.com>2014-03-22 14:28:12 -0400
commite61d99d96daedfea2f6ba071945ef0d2f86883c7 (patch)
treeb233af9a953a82d1f8f4230fd02dd6890493f796 /django/forms/utils.py
parent684e8a941bd0d08504718996c1afaf57957ce070 (diff)
downloaddjango-e61d99d96daedfea2f6ba071945ef0d2f86883c7.tar.gz
Fixed #20684 -- Added support for HTML5 boolean attributes to form widgets.
Diffstat (limited to 'django/forms/utils.py')
-rw-r--r--django/forms/utils.py27
1 files changed, 12 insertions, 15 deletions
diff --git a/django/forms/utils.py b/django/forms/utils.py
index 2147014a5d..f7f53e9a0a 100644
--- a/django/forms/utils.py
+++ b/django/forms/utils.py
@@ -2,7 +2,6 @@ from __future__ import unicode_literals
import json
import sys
-import warnings
try:
from collections import UserList
@@ -10,7 +9,6 @@ except ImportError: # Python 2
from UserList import UserList
from django.conf import settings
-from django.utils.deprecation import RemovedInDjango18Warning
from django.utils.encoding import force_text, python_2_unicode_compatible
from django.utils.html import format_html, format_html_join, escape
from django.utils import timezone
@@ -31,19 +29,18 @@ def flatatt(attrs):
The result is passed through 'mark_safe'.
"""
- for attr_name, value in attrs.items():
- if type(value) is bool:
- warnings.warn(
- "In Django 1.8, widget attribute %(attr_name)s=%(bool_value)s "
- "will %(action)s. To preserve current behavior, use the "
- "string '%(bool_value)s' instead of the boolean value." % {
- 'attr_name': attr_name,
- 'action': "be rendered as '%s'" % attr_name if value else "not be rendered",
- 'bool_value': value,
- },
- RemovedInDjango18Warning
- )
- return format_html_join('', ' {0}="{1}"', sorted(attrs.items()))
+ boolean_attrs = []
+ for attr, value in list(attrs.items()):
+ if value is True:
+ boolean_attrs.append((attr,))
+ del attrs[attr]
+ elif value is False:
+ del attrs[attr]
+
+ return (
+ format_html_join('', ' {0}="{1}"', sorted(attrs.items())) +
+ format_html_join('', ' {0}', sorted(boolean_attrs))
+ )
@python_2_unicode_compatible