summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiora Milbaum <liora@lmb.co.il>2022-10-16 08:00:31 +0300
committerNejc Habjan <hab.nejc@gmail.com>2022-10-16 20:37:39 +0200
commit3e4781a66577a6ded58f721739f8e9422886f9cd (patch)
tree25cce267314b5b0d65d14f6aea2e6ba4dfaf3537
parent124abab483ab6be71dbed91b8d518ae27355b9ae (diff)
downloadgitlab-3e4781a66577a6ded58f721739f8e9422886f9cd.tar.gz
refactor: pytest-docker fixtures
-rw-r--r--tests/functional/conftest.py26
-rw-r--r--tests/functional/fixtures/__init__.py0
-rw-r--r--tests/functional/fixtures/docker.py30
3 files changed, 31 insertions, 25 deletions
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
index 4cc4260..f494ac7 100644
--- a/tests/functional/conftest.py
+++ b/tests/functional/conftest.py
@@ -12,6 +12,7 @@ import requests
import gitlab
import gitlab.base
from tests.functional import helpers
+from tests.functional.fixtures.docker import * # noqa
SLEEP_TIME = 10
@@ -35,11 +36,6 @@ def gitlab_version(gl) -> GitlabVersion:
@pytest.fixture(scope="session")
-def docker_compose_command():
- return "docker compose"
-
-
-@pytest.fixture(scope="session")
def fixture_dir(test_dir) -> pathlib.Path:
return test_dir / "functional" / "fixtures"
@@ -161,26 +157,6 @@ def temp_dir() -> pathlib.Path:
@pytest.fixture(scope="session")
-def docker_compose_file(fixture_dir):
- return fixture_dir / "docker-compose.yml"
-
-
-@pytest.fixture(scope="session")
-def docker_compose_project_name():
- """Set a consistent project name to enable optional reuse of containers."""
- return "pytest-python-gitlab"
-
-
-@pytest.fixture(scope="session")
-def docker_cleanup(request):
- """Conditionally keep containers around by overriding the cleanup command."""
- if request.config.getoption("--keep-containers"):
- # Print version and exit.
- return "-v"
- return "down -v"
-
-
-@pytest.fixture(scope="session")
def check_is_alive():
"""
Return a healthcheck function fixture for the GitLab container spinup.
diff --git a/tests/functional/fixtures/__init__.py b/tests/functional/fixtures/__init__.py
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/tests/functional/fixtures/__init__.py
diff --git a/tests/functional/fixtures/docker.py b/tests/functional/fixtures/docker.py
new file mode 100644
index 0000000..1c72b50
--- /dev/null
+++ b/tests/functional/fixtures/docker.py
@@ -0,0 +1,30 @@
+"""
+pytest-docker fixture overrides.
+See https://github.com/avast/pytest-docker#available-fixtures.
+"""
+import pytest
+
+
+@pytest.fixture(scope="session")
+def docker_compose_command():
+ return "docker compose"
+
+
+@pytest.fixture(scope="session")
+def docker_compose_project_name():
+ """Set a consistent project name to enable optional reuse of containers."""
+ return "pytest-python-gitlab"
+
+
+@pytest.fixture(scope="session")
+def docker_compose_file(fixture_dir):
+ return fixture_dir / "docker-compose.yml"
+
+
+@pytest.fixture(scope="session")
+def docker_cleanup(request):
+ """Conditionally keep containers around by overriding the cleanup command."""
+ if request.config.getoption("--keep-containers"):
+ # Print version and exit.
+ return "-v"
+ return "down -v"