diff options
author | John L. Villalovos <john@sodarock.com> | 2022-01-09 22:11:47 -0800 |
---|---|---|
committer | John L. Villalovos <john@sodarock.com> | 2022-01-13 10:31:24 -0800 |
commit | 12435d74364ca881373d690eab89d2e2baa62a49 (patch) | |
tree | 7976389d86a50666458d3f45d2ca64fb6deb0e50 /gitlab/v4/objects/geo_nodes.py | |
parent | 824151ce9238f97118ec21aa8b3267cc7a2cd649 (diff) | |
download | gitlab-12435d74364ca881373d690eab89d2e2baa62a49.tar.gz |
fix: use url-encoded ID in all paths
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079
Diffstat (limited to 'gitlab/v4/objects/geo_nodes.py')
-rw-r--r-- | gitlab/v4/objects/geo_nodes.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/v4/objects/geo_nodes.py b/gitlab/v4/objects/geo_nodes.py index ebeb0d6..6633275 100644 --- a/gitlab/v4/objects/geo_nodes.py +++ b/gitlab/v4/objects/geo_nodes.py @@ -30,7 +30,7 @@ class GeoNode(SaveMixin, ObjectDeleteMixin, RESTObject): GitlabAuthenticationError: If authentication is not correct GitlabRepairError: If the server failed to perform the request """ - path = f"/geo_nodes/{self.get_id()}/repair" + path = f"/geo_nodes/{self.encoded_id}/repair" server_data = self.manager.gitlab.http_post(path, **kwargs) if TYPE_CHECKING: assert isinstance(server_data, dict) @@ -51,7 +51,7 @@ class GeoNode(SaveMixin, ObjectDeleteMixin, RESTObject): Returns: The status of the geo node """ - path = f"/geo_nodes/{self.get_id()}/status" + path = f"/geo_nodes/{self.encoded_id}/status" result = self.manager.gitlab.http_get(path, **kwargs) if TYPE_CHECKING: assert isinstance(result, dict) |