diff options
| author | John L. Villalovos <john@sodarock.com> | 2022-01-09 22:11:47 -0800 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2022-01-13 10:31:24 -0800 |
| commit | 12435d74364ca881373d690eab89d2e2baa62a49 (patch) | |
| tree | 7976389d86a50666458d3f45d2ca64fb6deb0e50 /gitlab/v4/objects/snippets.py | |
| parent | 824151ce9238f97118ec21aa8b3267cc7a2cd649 (diff) | |
| download | gitlab-12435d74364ca881373d690eab89d2e2baa62a49.tar.gz | |
fix: use url-encoded ID in all paths
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079
Diffstat (limited to 'gitlab/v4/objects/snippets.py')
| -rw-r--r-- | gitlab/v4/objects/snippets.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/v4/objects/snippets.py b/gitlab/v4/objects/snippets.py index 66459c0..9d9dcc4 100644 --- a/gitlab/v4/objects/snippets.py +++ b/gitlab/v4/objects/snippets.py @@ -50,7 +50,7 @@ class Snippet(UserAgentDetailMixin, SaveMixin, ObjectDeleteMixin, RESTObject): Returns: The snippet content """ - path = f"/snippets/{self.get_id()}/raw" + path = f"/snippets/{self.encoded_id}/raw" result = self.manager.gitlab.http_get( path, streamed=streamed, raw=True, **kwargs ) @@ -124,7 +124,7 @@ class ProjectSnippet(UserAgentDetailMixin, SaveMixin, ObjectDeleteMixin, RESTObj Returns: The snippet content """ - path = f"{self.manager.path}/{self.get_id()}/raw" + path = f"{self.manager.path}/{self.encoded_id}/raw" result = self.manager.gitlab.http_get( path, streamed=streamed, raw=True, **kwargs ) |