summaryrefslogtreecommitdiff
path: root/kafka
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2015-12-29 15:46:50 -0800
committerDana Powers <dana.powers@rd.io>2015-12-29 15:46:50 -0800
commit6dea93dfdb0b15270d5fd0ed630e21f319d9cea8 (patch)
tree9e3cadb2747956d799ddd28013a7071de20e65c7 /kafka
parentac57ada2bd73b5a7ab1c2060207c4c9c6f0ff9a9 (diff)
downloadkafka-python-6dea93dfdb0b15270d5fd0ed630e21f319d9cea8.tar.gz
Remove recursive client.poll call in ConsumerCoordinator
Diffstat (limited to 'kafka')
-rw-r--r--kafka/coordinator/consumer.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/kafka/coordinator/consumer.py b/kafka/coordinator/consumer.py
index 119e372..d5e166b 100644
--- a/kafka/coordinator/consumer.py
+++ b/kafka/coordinator/consumer.py
@@ -182,9 +182,10 @@ class ConsumerCoordinator(AbstractCoordinator):
# the leader will begin watching for changes to any of the topics
# the group is interested in, which ensures that all metadata changes
# will eventually be seen
+ # Because assignment typically happens within response callbacks,
+ # we cannot block on metadata updates here (no recursion into poll())
self._subscription.group_subscribe(all_subscribed_topics)
- future = self._client.set_topics(self._subscription.group_subscription())
- self._client.poll(future=future)
+ self._client.set_topics(self._subscription.group_subscription())
log.debug("Performing %s assignment for subscriptions %s",
assignor.name, member_metadata)