diff options
author | Dana Powers <dana.powers@gmail.com> | 2019-09-28 17:06:57 -0700 |
---|---|---|
committer | Dana Powers <dana.powers@gmail.com> | 2019-09-28 17:06:57 -0700 |
commit | 98ebff87a78bafbb15dd95c5174c5a1041a848ed (patch) | |
tree | 570ded42e9dca01d00c6230bc19c76b47f83fa44 /test/test_admin_integration.py | |
parent | 5381591bac7f1322e7a54e4be65d1a54e2898732 (diff) | |
download | kafka-python-98ebff87a78bafbb15dd95c5174c5a1041a848ed.tar.gz |
Fix Admin Client api version checking; only test ACL integration on 0.11+
Diffstat (limited to 'test/test_admin_integration.py')
-rw-r--r-- | test/test_admin_integration.py | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/test/test_admin_integration.py b/test/test_admin_integration.py index b3dc0cc..27028ce 100644 --- a/test/test_admin_integration.py +++ b/test/test_admin_integration.py @@ -8,10 +8,13 @@ from kafka.errors import NoError from kafka.admin import KafkaAdminClient, ACLFilter, ACLOperation, ACLPermissionType, ResourcePattern, ResourceType, ACL +# TODO: Convert to pytest / fixtures +# Note that ACL features require broker 0.11, but other admin apis may work on +# earlier broker versions class TestAdminClientIntegration(KafkaIntegrationTestCase): @classmethod def setUpClass(cls): # noqa - if env_kafka_version() < (0, 10): + if env_kafka_version() < (0, 11): return cls.zk = ZookeeperFixture.instance() @@ -19,19 +22,19 @@ class TestAdminClientIntegration(KafkaIntegrationTestCase): @classmethod def tearDownClass(cls): # noqa - if env_kafka_version() < (0, 10): + if env_kafka_version() < (0, 11): return cls.server.close() cls.zk.close() def setUp(self): - if env_kafka_version() < (0, 10): - self.skipTest('Admin Integration test requires KAFKA_VERSION >= 0.10') + if env_kafka_version() < (0, 11): + self.skipTest('Admin ACL Integration test requires KAFKA_VERSION >= 0.11') super(TestAdminClientIntegration, self).setUp() def tearDown(self): - if env_kafka_version() < (0, 10): + if env_kafka_version() < (0, 11): return super(TestAdminClientIntegration, self).tearDown() |