diff options
author | Ross Barnowski <rossbar@berkeley.edu> | 2023-04-03 10:31:25 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-03 13:31:25 -0400 |
commit | cf7158efc5261a49d0cf9f10a09ff51aeb831c30 (patch) | |
tree | 0b87ea1fb9ed9d0f66a2d38daf8528f2edfaa6d0 | |
parent | 7366c9f5352352e562d5081cdaff042a15a73f72 (diff) | |
download | networkx-cf7158efc5261a49d0cf9f10a09ff51aeb831c30.tar.gz |
Better default alpha value for viz attributes in gexf writer (#6612)
* Add test that fails with current default ('None')
* Update default alpha value.
Co-authored-by: Dan Schult <dschult@colgate.edu>
---------
Co-authored-by: Dan Schult <dschult@colgate.edu>
-rw-r--r-- | networkx/readwrite/gexf.py | 2 | ||||
-rw-r--r-- | networkx/readwrite/tests/test_gexf.py | 10 |
2 files changed, 11 insertions, 1 deletions
diff --git a/networkx/readwrite/gexf.py b/networkx/readwrite/gexf.py index ab7e26ab..e7e8a2b3 100644 --- a/networkx/readwrite/gexf.py +++ b/networkx/readwrite/gexf.py @@ -569,7 +569,7 @@ class GEXFWriter(GEXF): r=str(color.get("r")), g=str(color.get("g")), b=str(color.get("b")), - a=str(color.get("a")), + a=str(color.get("a", 1.0)), ) element.append(e) diff --git a/networkx/readwrite/tests/test_gexf.py b/networkx/readwrite/tests/test_gexf.py index eba6aed7..95c29f90 100644 --- a/networkx/readwrite/tests/test_gexf.py +++ b/networkx/readwrite/tests/test_gexf.py @@ -491,6 +491,16 @@ gexf.net/1.2draft http://www.gexf.net/1.2draft/gexf.xsd" version="1.2"> sorted(e) for e in H.edges() ) + # Test missing alpha value for version >draft1.1 - set default alpha value + # to 1.0 instead of `None` when writing for better general compatibility + fh = io.BytesIO() + # G.nodes[0]["viz"]["color"] does not have an alpha value explicitly defined + # so the default is used instead + nx.write_gexf(G, fh, version="1.2draft") + fh.seek(0) + H = nx.read_gexf(fh, node_type=int) + assert H.nodes[0]["viz"]["color"]["a"] == 1.0 + # Second graph for the other branch G = nx.Graph() G.add_node(0, label="1", color="green") |