summaryrefslogtreecommitdiff
path: root/openid/test/test_etxrd.py
diff options
context:
space:
mode:
Diffstat (limited to 'openid/test/test_etxrd.py')
-rw-r--r--openid/test/test_etxrd.py12
1 files changed, 8 insertions, 4 deletions
diff --git a/openid/test/test_etxrd.py b/openid/test/test_etxrd.py
index bc7d78f..c945583 100644
--- a/openid/test/test_etxrd.py
+++ b/openid/test/test_etxrd.py
@@ -88,7 +88,8 @@ class TestParseXRDS(unittest.TestCase):
class TestServiceParser(unittest.TestCase):
def setUp(self):
- self.xmldoc = open(XRD_FILE, 'rb').read()
+ with open(XRD_FILE, 'rb') as xrd_file:
+ self.xmldoc = xrd_file.read()
self.yadis_url = 'http://unittest.url/'
def _getServices(self, flt=None):
@@ -156,7 +157,8 @@ class TestServiceParser(unittest.TestCase):
def testNoXRDS(self):
"""Make sure that we get an exception when an XRDS element is
not present"""
- self.xmldoc = open(NOXRDS_FILE, 'rb').read()
+ with open(NOXRDS_FILE, 'rb') as xml_file:
+ self.xmldoc = xml_file.read()
self.assertRaises(etxrd.XRDSError, services.applyFilter, self.yadis_url, self.xmldoc, None)
def testEmpty(self):
@@ -168,7 +170,8 @@ class TestServiceParser(unittest.TestCase):
def testNoXRD(self):
"""Make sure that we get an exception when there is no XRD
element present."""
- self.xmldoc = open(NOXRD_FILE, 'rb').read()
+ with open(NOXRD_FILE, 'rb') as xml_file:
+ self.xmldoc = xml_file.read()
self.assertRaises(etxrd.XRDSError, services.applyFilter, self.yadis_url, self.xmldoc, None)
@@ -181,7 +184,8 @@ class TestCanonicalID(unittest.TestCase):
filename = datapath(filename)
def test(self):
- xrds = etxrd.parseXRDS(open(filename, 'rb').read())
+ with open(filename, 'rb') as xrds_file:
+ xrds = etxrd.parseXRDS(xrds_file.read())
self._getCanonicalID(iname, xrds, expectedID)
return test