diff options
| author | Nguyen Van Duc <ducnv@vn.fujitsu.com> | 2018-06-11 17:26:24 +0700 |
|---|---|---|
| committer | Tovin Seven <vinhnt@vn.fujitsu.com> | 2018-06-26 04:01:41 +0000 |
| commit | 5ea78ce95093c6773f67e5ce42c1946de0dba3d2 (patch) | |
| tree | 0e13ceaa3aaa4bbb0ac7a2e50700172d019890c7 /osprofiler/drivers | |
| parent | 4a2f00200510d9c8659c1f59f52054ee4615fcaa (diff) | |
| download | osprofiler-5ea78ce95093c6773f67e5ce42c1946de0dba3d2.tar.gz | |
Put 'db' parameter back and provide a deprecation warning before remove
The parameter should have been deprecated before its removal to give
callers a chance to adjust their calls to the new argument list.
This patchset follows Ben Nemec's comment in commit
https://review.openstack.org/#/c/569078/
Change-Id: I606796a33f6304276fe78b9868239a0ee5b9f46a
Diffstat (limited to 'osprofiler/drivers')
| -rw-r--r-- | osprofiler/drivers/redis_driver.py | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/osprofiler/drivers/redis_driver.py b/osprofiler/drivers/redis_driver.py index 12439a8..2c2e020 100644 --- a/osprofiler/drivers/redis_driver.py +++ b/osprofiler/drivers/redis_driver.py @@ -14,6 +14,8 @@ # License for the specific language governing permissions and limitations # under the License. +from debtcollector import removals + from oslo_config import cfg from oslo_serialization import jsonutils import six.moves.urllib.parse as parser @@ -23,7 +25,11 @@ from osprofiler import exc class Redis(base.Driver): - def __init__(self, connection_str, project=None, + @removals.removed_kwarg("db", message="'db' parameter is deprecated " + "and will be removed in future. " + "Please specify 'db' in " + "'connection_string' instead.") + def __init__(self, connection_str, db=0, project=None, service=None, host=None, conf=cfg.CONF, **kwargs): """Redis driver for OSProfiler.""" @@ -146,7 +152,11 @@ class Redis(base.Driver): class RedisSentinel(Redis, base.Driver): - def __init__(self, connection_str, project=None, + @removals.removed_kwarg("db", message="'db' parameter is deprecated " + "and will be removed in future. " + "Please specify 'db' in " + "'connection_string' instead.") + def __init__(self, connection_str, db=0, project=None, service=None, host=None, conf=cfg.CONF, **kwargs): """Redis driver for OSProfiler.""" |