test_wsgirequest_charset: Use UTF-8 instead of iso-8859-1test_wsgirequest_charset_use_UTF-8_instead_of_iso-8859-1

because it seems that the defacto standard for encoding URIs is to use UTF-8.

I've been reading about url encoding and it seems like perhaps using an
encoding other than UTF-8 is very non-standard and not well-supported (this
test is trying to use `iso-8859-1`).

From http://en.wikipedia.org/wiki/Percent-encoding

> For a non-ASCII character, it is typically converted to its byte sequence in
> UTF-8, and then each byte value is represented as above.

> The generic URI syntax mandates that new URI schemes that provide for the
> representation of character data in a URI must, in effect, represent
> characters from the unreserved set without translation, and should convert
> all other characters to bytes according to UTF-8, and then percent-encode
> those values. This requirement was introduced in January 2005 with the
> publication of RFC 3986

From http://tools.ietf.org/html/rfc3986:

> Non-ASCII characters must first be encoded according to UTF-8 [STD63], and
> then each octet of the corresponding UTF-8 sequence must be percent-encoded
> to be represented as URI characters.  URI producing applications must not use
> percent-encoding in host unless it is used to represent a UTF-8 character
> sequence.

From http://tools.ietf.org/html/rfc3987:

> Conversions from URIs to IRIs MUST NOT use any character encoding other than
> UTF-8 in steps 3 and 4, even if it might be possible to guess from the
> context that another character encoding than UTF-8 was used in the URI.  For
> example, the URI "http://www.example.org/r%E9sum%E9.html" might with some
> guessing be interpreted to contain two e-acute characters encoded as
> iso-8859-1. It must not be converted to an IRI containing these e-acute
> characters.  Otherwise, in the future the IRI will be mapped to
> "http://www.example.org/r%C3%A9sum%C3%A9.html", which is a different URI from
> "http://www.example.org/r%E9sum%E9.html".

See issue #7, which I think this at least partially fixes.

1 files changed, 78 insertions, 0 deletions

diff --git a/tests/test_cgitb_catcher.py b/tests/test_cgitb_catcher.py
new file mode 100644
index 0000000..a63f7d8
--- /dev/null
+++ b/tests/test_cgitb_catcher.py
@@ -0,0 +1,78 @@
+from paste.fixture import *
+from paste.cgitb_catcher import CgitbMiddleware
+from paste import lint
+from .test_exceptions.test_error_middleware import clear_middleware
+
+def do_request(app, expect_status=500):
+    app = lint.middleware(app)
+    app = CgitbMiddleware(app, {}, display=True)
+    app = clear_middleware(app)
+    testapp = TestApp(app)
+    res = testapp.get('', status=expect_status,
+                      expect_errors=True)
+    return res
+
+
+############################################################
+## Applications that raise exceptions
+############################################################
+
+def bad_app():
+    "No argument list!"
+    return None
+
+def start_response_app(environ, start_response):
+    "raise error before start_response"
+    raise ValueError("hi")
+
+def after_start_response_app(environ, start_response):
+    start_response("200 OK", [('Content-type', 'text/plain')])
+    raise ValueError('error2')
+
+def iter_app(environ, start_response):
+    start_response("200 OK", [('Content-type', 'text/plain')])
+    return yielder([b'this', b' is ', b' a', None])
+
+def yielder(args):
+    for arg in args:
+        if arg is None:
+            raise ValueError("None raises error")
+        yield arg
+
+############################################################
+## Tests
+############################################################
+
+def test_makes_exception():
+    res = do_request(bad_app)
+    print(res)
+    if six.PY3:
+        assert 'bad_app() takes 0 positional arguments but 2 were given' in res
+    else:
+        assert 'bad_app() takes no arguments (2 given' in res
+    assert 'iterator = application(environ, start_response_wrapper)' in res
+    assert 'lint.py' in res
+    assert 'cgitb_catcher.py' in res
+
+def test_start_res():
+    res = do_request(start_response_app)
+    print(res)
+    assert 'ValueError: hi' in res
+    assert 'test_cgitb_catcher.py' in res
+    assert 'line 26, in start_response_app' in res
+
+def test_after_start():
+    res = do_request(after_start_response_app, 200)
+    print(res)
+    assert 'ValueError: error2' in res
+    assert 'line 30' in res
+
+def test_iter_app():
+    res = do_request(iter_app, 200)
+    print(res)
+    assert 'None raises error' in res
+    assert 'yielder' in res
+
+
+
+