summaryrefslogtreecommitdiff
path: root/tox.ini
diff options
context:
space:
mode:
authorChris Dent <chris.dent@gmail.com>2019-01-04 17:45:39 +0000
committerChris Dent <chris.dent@gmail.com>2019-01-04 17:45:39 +0000
commitedd3469847bd943ac28ff85607d585555290f650 (patch)
treea495df2695c2b0a87c9b2dd73a0793ec889b4c68 /tox.ini
parent5015532233dc25bf1594f79c0af7daf8d59a5f80 (diff)
downloadpaste-git-fix-19.tar.gz
Remove use of _lock around get and set timeout of SSL connectionfix-19
The maintainers of pyOpenSSL have deprecated the tsafe module because it is neither used nor complete. It was removed from in paste in 78dd2ec01384 but because of a lack of test coverage it caused a regression as described in #19. Reviewing the code and pyOpenSSL, it appears that the right fix is to simply not subclass the SSL.Connection, and let get and set timeout be called on the socket object that Connection keeps, without a lock. A concern here is that if someone is doing something multi- threaded with paste/httpserver the removal of the use of tsafe may present some issues. On the other hand, if someone is doing something multi-threaded, one hopes they are using a more robust web and modern web server. Fixes #19
Diffstat (limited to 'tox.ini')
0 files changed, 0 insertions, 0 deletions