summaryrefslogtreecommitdiff
path: root/psycopg/win32_support.h
diff options
context:
space:
mode:
authorAlexander Kukushkin <alexander.kukushkin@zalando.de>2019-05-06 10:27:44 +0200
committerAlexander Kukushkin <alexander.kukushkin@zalando.de>2019-05-06 10:27:44 +0200
commit6cff5a3e089f155519765f9cdd49ef78b23ab740 (patch)
tree204f14d008cebd8deada2b90fb6e8692139a969b /psycopg/win32_support.h
parent325aadbf2c598a172a1aaa0e083677bd06c8451e (diff)
downloadpsycopg2-6cff5a3e089f155519765f9cdd49ef78b23ab740.tar.gz
Smart replication feedback
This commit makes psycopg2 responsible for sending the status update (feedback) messages to the server regardless of whether a synchronous or asynchronous connection is used. Feedback is sent every *status_update* (default value is 10) seconds, which could be configured by passing a corresponding parameter to the `start_replication()` or `start_replication_expert()` methods. The actual feedback message is sent by the `pq_read_replication_message()` when the *status_update* timeout is reached. The default behavior of the `send_feedback()` method is changed. It doesn't send a feedback message on every call anymore but just updates internal structures. There is still a way to *force* sending a message if *force* or *reply* parameters are set. The new approach has certain advantages: 1. The client can simply call the `send_feedback()` for every processed message and the library will take care of not overwhelming the server. Actually, in the synchronous mode it is even mandatory to confirm every processed message. 2. The library tracks internally the pointer of the last received message which is not keepalive. If the client confirmed the last message and after that server sends only keepalives with increasing *wal_end*, the library can safely move forward *flush* position to the *wal_end* and later automatically report it to the server. Reporting of the *wal_end* received from keepalive messages is very important. Not doing so casing: 1. Excessive disk usage, because the replication slot prevents from WAL being cleaned up. 2. The smart and fast shutdown of the server could last indefinitely because walsender waits until the client report *flush* position equal to the *wal_end*. This implementation is only extending the existing API and therefore should not break any of the existing code.
Diffstat (limited to 'psycopg/win32_support.h')
-rw-r--r--psycopg/win32_support.h7
1 files changed, 7 insertions, 0 deletions
diff --git a/psycopg/win32_support.h b/psycopg/win32_support.h
index 57b308b..a49d5de 100644
--- a/psycopg/win32_support.h
+++ b/psycopg/win32_support.h
@@ -43,6 +43,13 @@ extern HIDDEN void timeradd(struct timeval *a, struct timeval *b, struct timeval
#endif
extern HIDDEN void timersub(struct timeval *a, struct timeval *b, struct timeval *c);
+
+#ifndef timercmp
+#define timercmp(a, b, cmp) \
+ (((a)->tv_sec == (b)->tv_sec) ? \
+ ((a)->tv_usec cmp (b)->tv_usec) : \
+ ((a)->tv_sec cmp (b)->tv_sec))
+#endif
#endif
#endif /* !defined(PSYCOPG_WIN32_SUPPORT_H) */