diff options
| author | Benjamin Foster <bfoster@phi.al> | 2015-08-11 22:07:28 +0100 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2015-08-19 15:44:57 +0900 |
| commit | 57479fa55d4566b10ef16c776f1253fbfcb0b17e (patch) | |
| tree | ccfc4ef055e66e034f6090c0acd585ed428d8d69 | |
| parent | 95380072e46d1948bda9e65fcfd5e1874500a80a (diff) | |
| download | pygerrit-57479fa55d4566b10ef16c776f1253fbfcb0b17e.tar.gz | |
Updated add_comment() to support line ranges
add_comment() now supports 'ranges' as described by the gerrit API, by
using the keyword 'range' instead of 'line', and a dict with the four
required keys.
Closes #31
Change-Id: Iaa7004e4f94794df8546a153227375e7be4b06bb
| -rw-r--r-- | pygerrit/rest/__init__.py | 24 |
1 files changed, 19 insertions, 5 deletions
diff --git a/pygerrit/rest/__init__.py b/pygerrit/rest/__init__.py index 31e5b3e..49cc434 100644 --- a/pygerrit/rest/__init__.py +++ b/pygerrit/rest/__init__.py @@ -248,15 +248,29 @@ class GerritReview(object): 'line': 10, 'message': 'inline message'}]) + add_comments([{'filename': 'Makefile', + 'range': {'start_line': 0, + 'start_character': 1, + 'end_line': 0, + 'end_character': 5}, + 'message': 'inline message'}]) + """ for comment in comments: - if 'filename' and 'line' and 'message' in comment.keys(): - line_msg = {"line": comment['line'], - "message": comment['message']} - file_comment = {comment['filename']: [line_msg]} + if 'filename' and 'message' in comment.keys(): + msg = {} + if 'range' in comment.keys(): + msg = {"range": comment['range'], + "message": comment['message']} + elif 'line' in comment.keys(): + msg = {"line": comment['line'], + "message": comment['message']} + else: + continue + file_comment = {comment['filename']: [msg]} if self.comments: if comment['filename'] in self.comments.keys(): - self.comments[comment['filename']].append(line_msg) + self.comments[comment['filename']].append(msg) else: self.comments.update(file_comment) else: |