summaryrefslogtreecommitdiff
path: root/pylint/checkers/refactoring/recommendation_checker.py
diff options
context:
space:
mode:
authorYu Shao, Pang <p.yushao2@gmail.com>2021-06-30 22:02:34 +0800
committerPierre Sassoulas <pierre.sassoulas@gmail.com>2021-07-01 10:13:58 +0200
commit86970f027c1b391556632dc99865ad7df9350a28 (patch)
tree9b0089da44ee0abaa61346cf195742629406e5ee /pylint/checkers/refactoring/recommendation_checker.py
parentba92c33826d766af5df6b0bf00ea4010d8a67bda (diff)
downloadpylint-git-86970f027c1b391556632dc99865ad7df9350a28.tar.gz
fix false positive of `consider-using-dict-items`
Diffstat (limited to 'pylint/checkers/refactoring/recommendation_checker.py')
-rw-r--r--pylint/checkers/refactoring/recommendation_checker.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/pylint/checkers/refactoring/recommendation_checker.py b/pylint/checkers/refactoring/recommendation_checker.py
index 6ea387126..d7d48e031 100644
--- a/pylint/checkers/refactoring/recommendation_checker.py
+++ b/pylint/checkers/refactoring/recommendation_checker.py
@@ -233,7 +233,7 @@ class RecommendationChecker(checkers.BaseChecker):
and subscript == subscript.parent.target
):
# Ignore this subscript if it is the target of an assignment
- continue
+ return # Early termination as dict index lookup is necessary
self.add_message("consider-using-dict-items", node=node)
return