Migrate from utils.check_messages to utils.only_required_for_messages (#6432)

1 files changed, 18 insertions, 16 deletions

diff --git a/pylint/checkers/refactoring/refactoring_checker.py b/pylint/checkers/refactoring/refactoring_checker.py
index 60f10f70e..e85538a7e 100644
--- a/pylint/checkers/refactoring/refactoring_checker.py
+++ b/pylint/checkers/refactoring/refactoring_checker.py
@@ -604,7 +604,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
                 if self.linter.is_message_enabled("trailing-comma-tuple"):
                     self.add_message("trailing-comma-tuple", line=token.start[0])
 
-    @utils.check_messages("consider-using-with")
+    @utils.only_required_for_messages("consider-using-with")
     def leave_module(self, _: nodes.Module) -> None:
         # check for context managers that have been created but not used
         self._emit_consider_using_with_if_needed(
@@ -612,7 +612,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         )
         self._init()
 
-    @utils.check_messages("too-many-nested-blocks")
+    @utils.only_required_for_messages("too-many-nested-blocks")
     def visit_tryexcept(self, node: nodes.TryExcept) -> None:
         self._check_nested_blocks(node)
 
@@ -640,7 +640,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
                     args=(name_node.name,),
                 )
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "redefined-argument-from-local",
         "too-many-nested-blocks",
         "unnecessary-dict-index-lookup",
@@ -654,12 +654,14 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         for name in node.target.nodes_of_class(nodes.AssignName):
             self._check_redefined_argument_from_local(name)
 
-    @utils.check_messages("redefined-argument-from-local")
+    @utils.only_required_for_messages("redefined-argument-from-local")
     def visit_excepthandler(self, node: nodes.ExceptHandler) -> None:
         if node.name and isinstance(node.name, nodes.AssignName):
             self._check_redefined_argument_from_local(node.name)
 
-    @utils.check_messages("redefined-argument-from-local", "consider-using-with")
+    @utils.only_required_for_messages(
+        "redefined-argument-from-local", "consider-using-with"
+    )
     def visit_with(self, node: nodes.With) -> None:
         for var, names in node.items:
             if isinstance(var, nodes.Name):
@@ -766,7 +768,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         ):
             self.add_message("consider-using-get", node=node)
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "too-many-nested-blocks",
         "simplifiable-if-statement",
         "no-else-return",
@@ -866,7 +868,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
                 "consider-using-min-builtin", node=node, args=(reduced_to,)
             )
 
-    @utils.check_messages("simplifiable-if-expression")
+    @utils.only_required_for_messages("simplifiable-if-expression")
     def visit_ifexp(self, node: nodes.IfExp) -> None:
         self._check_simplifiable_ifexp(node)
 
@@ -895,7 +897,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
 
         self.add_message("simplifiable-if-expression", node=node, args=(reduced_to,))
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "too-many-nested-blocks",
         "inconsistent-return-statements",
         "useless-return",
@@ -917,7 +919,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         )
         self._consider_using_with_stack.function_scope.clear()
 
-    @utils.check_messages("consider-using-with")
+    @utils.only_required_for_messages("consider-using-with")
     def leave_classdef(self, _: nodes.ClassDef) -> None:
         # check for context managers that have been created but not used
         self._emit_consider_using_with_if_needed(
@@ -925,7 +927,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         )
         self._consider_using_with_stack.class_scope.clear()
 
-    @utils.check_messages("stop-iteration-return")
+    @utils.only_required_for_messages("stop-iteration-return")
     def visit_raise(self, node: nodes.Raise) -> None:
         self._check_stop_iteration_inside_generator(node)
 
@@ -1013,7 +1015,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
                         args=(call_name, inside_comp),
                     )
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "stop-iteration-return",
         "consider-using-dict-comprehension",
         "consider-using-set-comprehension",
@@ -1369,7 +1371,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
                 args=(node.as_string(), simplified_expr.as_string()),
             )
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "consider-merging-isinstance",
         "consider-using-in",
         "chained-comparison",
@@ -1406,7 +1408,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
             message = "consider-swap-variables"
             self.add_message(message, node=node)
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "simplify-boolean-expression",
         "consider-using-ternary",
         "consider-swap-variables",
@@ -1416,7 +1418,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         self._append_context_managers_to_stack(node)
         self.visit_return(node)  # remaining checks are identical as for return nodes
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "simplify-boolean-expression",
         "consider-using-ternary",
         "consider-swap-variables",
@@ -1566,11 +1568,11 @@ class RefactoringChecker(checkers.BaseTokenChecker):
         if is_concat_loop:
             self.add_message("consider-using-join", node=aug_assign)
 
-    @utils.check_messages("consider-using-join")
+    @utils.only_required_for_messages("consider-using-join")
     def visit_augassign(self, node: nodes.AugAssign) -> None:
         self._check_consider_using_join(node)
 
-    @utils.check_messages(
+    @utils.only_required_for_messages(
         "unnecessary-comprehension",
         "unnecessary-dict-index-lookup",
         "unnecessary-list-index-lookup",