summaryrefslogtreecommitdiff
path: root/pylint/graph.py
diff options
context:
space:
mode:
authorClaudiu Popa <cpopa@cloudbasesolutions.com>2015-08-18 23:28:24 +0300
committerClaudiu Popa <cpopa@cloudbasesolutions.com>2015-08-18 23:28:24 +0300
commit7307bed1f99ef00bb76f7c0cce90aad57570c9b1 (patch)
tree7e3816b6a72eae0347301aef5d5cc83153794901 /pylint/graph.py
parent438be0ec6942350b4659d0ea62024f8f918f3676 (diff)
downloadpylint-git-7307bed1f99ef00bb76f7c0cce90aad57570c9b1.tar.gz
Fix pylint warnings for the code imported from logilab-common.
Diffstat (limited to 'pylint/graph.py')
-rw-r--r--pylint/graph.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/pylint/graph.py b/pylint/graph.py
index 9e4cab5bf..492f8fd06 100644
--- a/pylint/graph.py
+++ b/pylint/graph.py
@@ -36,7 +36,9 @@ def target_info_from_filename(filename):
class DotBackend(object):
"""Dot File backend."""
def __init__(self, graphname, rankdir=None, size=None, ratio=None,
- charset='utf-8', renderer='dot', additionnal_param={}):
+ charset='utf-8', renderer='dot', additional_param=None):
+ if additional_param is None:
+ additional_param = {}
self.graphname = graphname
self.renderer = renderer
self.lines = []
@@ -52,7 +54,7 @@ class DotBackend(object):
assert charset.lower() in ('utf-8', 'iso-8859-1', 'latin1'), \
'unsupported charset %s' % charset
self.emit('charset="%s"' % charset)
- for param in additionnal_param.items():
+ for param in additional_param.items():
self.emit('='.join(param))
def get_source(self):
@@ -83,7 +85,7 @@ class DotBackend(object):
else:
dotfile = '%s.dot' % name
if outputfile is not None:
- storedir, basename, target = target_info_from_filename(outputfile)
+ storedir, _, target = target_info_from_filename(outputfile)
if target != "dot":
pdot, dot_sourcepath = tempfile.mkstemp(".dot", name)
os.close(pdot)
@@ -104,11 +106,13 @@ class DotBackend(object):
else:
use_shell = False
if mapfile:
- subprocess.call([self.renderer, '-Tcmapx', '-o', mapfile, '-T', target, dot_sourcepath, '-o', outputfile],
+ subprocess.call([self.renderer, '-Tcmapx', '-o',
+ mapfile, '-T', target, dot_sourcepath,
+ '-o', outputfile],
shell=use_shell)
else:
- subprocess.call([self.renderer, '-T', target,
- dot_sourcepath, '-o', outputfile],
+ subprocess.call([self.renderer, '-T', target,
+ dot_sourcepath, '-o', outputfile],
shell=use_shell)
os.unlink(dot_sourcepath)
return outputfile
@@ -123,7 +127,7 @@ class DotBackend(object):
"""
attrs = ['%s="%s"' % (prop, value) for prop, value in props.items()]
n_from, n_to = normalize_node_id(name1), normalize_node_id(name2)
- self.emit('%s -> %s [%s];' % (n_from, n_to, ', '.join(sorted(attrs))) )
+ self.emit('%s -> %s [%s];' % (n_from, n_to, ', '.join(sorted(attrs))))
def emit_node(self, name, **props):
"""emit a node with given properties.