[use-implicit-booleaness] Fix comparison to empty strings across the codebase (#7722)

As it will become a default check in #6870 it will be easier to review it if we separate the two

2 files changed, 6 insertions, 7 deletions

diff --git a/pylint/testutils/_primer/primer_compare_command.py b/pylint/testutils/_primer/primer_compare_command.py
index baf28d8b7..442ffa227 100644
--- a/pylint/testutils/_primer/primer_compare_command.py
+++ b/pylint/testutils/_primer/primer_compare_command.py
@@ -63,15 +63,14 @@ class CompareCommand(PrimerCommand):
             comment += self._create_comment_for_package(
                 package, new_messages, missing_messages
             )
-        if comment == "":
-            comment = (
+        comment = (
+            f"🤖 **Effect of this PR on checked open source code:** 🤖\n\n{comment}"
+            if comment
+            else (
                 "🤖 According to the primer, this change has **no effect** on the"
                 " checked open source code. 🤖🎉\n\n"
             )
-        else:
-            comment = (
-                f"🤖 **Effect of this PR on checked open source code:** 🤖\n\n{comment}"
-            )
+        )
         return self._truncate_comment(comment)
 
     def _create_comment_for_package(
diff --git a/pylint/testutils/utils.py b/pylint/testutils/utils.py
index 4d5b82867..292e991c2 100644
--- a/pylint/testutils/utils.py
+++ b/pylint/testutils/utils.py
@@ -93,7 +93,7 @@ def create_files(paths: list[str], chroot: str = ".") -> None:
         path = os.path.join(chroot, path)
         filename = os.path.basename(path)
         # path is a directory path
-        if filename == "":
+        if not filename:
             dirs.add(path)
         # path is a filename path
         else: