summaryrefslogtreecommitdiff
path: root/pylint
diff options
context:
space:
mode:
authorMark Byrne <31762852+mbyrnepr2@users.noreply.github.com>2023-04-13 08:46:51 +0200
committerGitHub <noreply@github.com>2023-04-13 06:46:51 +0000
commit56fa5dce747a46f1dcba6eca003bb22fcc347247 (patch)
treee534e85bdad1f79295aa4a0812d0f12dc54e2093 /pylint
parent0cd41b1fb15e31eb311b61f93bc27f7cacc2f7ac (diff)
downloadpylint-git-56fa5dce747a46f1dcba6eca003bb22fcc347247.tar.gz
Fix false positive for ``keyword-arg-before-vararg`` (#8571)
* Fix false positive for ``keyword-arg-before-vararg`` when a positional-only parameter with a default value precedes ``*args``. Closes #8570
Diffstat (limited to 'pylint')
-rw-r--r--pylint/checkers/typecheck.py8
1 files changed, 7 insertions, 1 deletions
diff --git a/pylint/checkers/typecheck.py b/pylint/checkers/typecheck.py
index 7605d6b67..6dac7ede5 100644
--- a/pylint/checkers/typecheck.py
+++ b/pylint/checkers/typecheck.py
@@ -1001,8 +1001,14 @@ accessed. Python regular expressions are accepted.",
@only_required_for_messages("keyword-arg-before-vararg")
def visit_functiondef(self, node: nodes.FunctionDef) -> None:
- # check for keyword arg before varargs
+ # check for keyword arg before varargs.
+
if node.args.vararg and node.args.defaults:
+ # When `positional-only` parameters are present then only
+ # `positional-or-keyword` parameters are checked. I.e:
+ # >>> def name(pos_only_params, /, pos_or_keyword_params, *args): ...
+ if node.args.posonlyargs and not node.args.args:
+ return
self.add_message("keyword-arg-before-vararg", node=node, args=(node.name))
visit_asyncfunctiondef = visit_functiondef