diff options
author | Daniƫl van Noord <13665637+DanielNoord@users.noreply.github.com> | 2022-04-16 14:09:28 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-16 14:09:28 +0200 |
commit | 69676a5348672e2af76c1e99d210698b431829f9 (patch) | |
tree | 8ef34e2410aa835a1733fa0370455297d1fae3f4 /tests/checkers | |
parent | 0bd2e5aa3edd827e21cf6d1d8cc5900567a54a01 (diff) | |
download | pylint-git-69676a5348672e2af76c1e99d210698b431829f9.tar.gz |
Improve the ``__gt__`` method of Checkers (#6355)
Diffstat (limited to 'tests/checkers')
-rw-r--r-- | tests/checkers/unittest_base_checker.py | 34 |
1 files changed, 31 insertions, 3 deletions
diff --git a/tests/checkers/unittest_base_checker.py b/tests/checkers/unittest_base_checker.py index 38f06708b..1fcdcfc9d 100644 --- a/tests/checkers/unittest_base_checker.py +++ b/tests/checkers/unittest_base_checker.py @@ -6,6 +6,9 @@ from pylint.checkers import BaseChecker +from pylint.checkers.imports import ImportsChecker +from pylint.checkers.typecheck import TypeChecker +from pylint.extensions.while_used import WhileChecker from pylint.lint.pylinter import PyLinter @@ -41,7 +44,7 @@ class DifferentBasicChecker(BaseChecker): def __init__(self) -> None: super().__init__(PyLinter()) - name = "different" + name = "a-different-checker" msgs = { "W0002": ( "Blah blah example.", @@ -87,9 +90,34 @@ Basic checker Messages def test_base_checker_ordering() -> None: """Test ordering of checkers based on their __gt__ method.""" + linter = PyLinter() fake_checker_1 = OtherBasicChecker() fake_checker_2 = LessBasicChecker() fake_checker_3 = DifferentBasicChecker() - assert fake_checker_1 < fake_checker_3 - assert fake_checker_2 < fake_checker_3 + import_checker = ImportsChecker(linter) + while_checker = WhileChecker(linter) + type_checker = TypeChecker(linter) + + list_of_checkers = [ + 1, + fake_checker_1, + fake_checker_2, + fake_checker_3, + type_checker, + import_checker, + while_checker, + linter, + ] + assert sorted(list_of_checkers) == [ # type: ignore[type-var] + linter, + import_checker, + type_checker, + fake_checker_3, + fake_checker_1, + fake_checker_2, + while_checker, + 1, + ] + assert fake_checker_1 > fake_checker_3 + assert fake_checker_2 > fake_checker_3 assert fake_checker_1 == fake_checker_2 |