Create common ``Printer`` base class for ``pyreverse`` and improve typing. (#4731)

* Create common ``Printer`` base class for Pyreverse, and improve typing.
* Use ``abc.ABC`` as metaclass for ``Printer`` instead of raising ``NotImplementedError``
* Rename ``vcgutils.py`` to ``vcg_printer.py``

4 files changed, 82 insertions, 16 deletions

diff --git a/tests/data/classes_No_Name.dot b/tests/data/classes_No_Name.dot
index c5eb70f0c..c0141fd2a 100644
--- a/tests/data/classes_No_Name.dot
+++ b/tests/data/classes_No_Name.dot
@@ -1,14 +1,14 @@
 digraph "classes_No_Name" {
-charset="utf-8"
 rankdir=BT
-"0" [label="{Ancestor|attr : str\lcls_member\l|get_value()\lset_value(value)\l}", shape="record"];
-"1" [label="{DoNothing|\l|}", shape="record"];
-"2" [label="{DoNothing2|\l|}", shape="record"];
-"3" [label="{Interface|\l|get_value()\lset_value(value)\l}", shape="record"];
-"4" [label="{Specialization|TYPE : str\lrelation\lrelation2\ltop : str\l|}", shape="record"];
-"4" -> "0" [arrowhead="empty", arrowtail="none"];
-"0" -> "3" [arrowhead="empty", arrowtail="node", style="dashed"];
-"1" -> "0" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="cls_member", style="solid"];
-"1" -> "4" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="relation", style="solid"];
-"2" -> "4" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="relation2", style="solid"];
+charset="utf-8"
+"data.clientmodule_test.Ancestor" [color="black", fontcolor="black", label="{Ancestor|attr : str\lcls_member\l|get_value()\lset_value(value)\l}", shape="record", style="solid"];
+"data.suppliermodule_test.DoNothing" [color="black", fontcolor="black", label="{DoNothing|\l|}", shape="record", style="solid"];
+"data.suppliermodule_test.DoNothing2" [color="black", fontcolor="black", label="{DoNothing2|\l|}", shape="record", style="solid"];
+"data.suppliermodule_test.Interface" [color="black", fontcolor="black", label="{Interface|\l|get_value()\lset_value(value)\l}", shape="record", style="solid"];
+"data.clientmodule_test.Specialization" [color="black", fontcolor="black", label="{Specialization|TYPE : str\lrelation\lrelation2\ltop : str\l|}", shape="record", style="solid"];
+"data.clientmodule_test.Specialization" -> "data.clientmodule_test.Ancestor" [arrowhead="empty", arrowtail="none"];
+"data.clientmodule_test.Ancestor" -> "data.suppliermodule_test.Interface" [arrowhead="empty", arrowtail="node", style="dashed"];
+"data.suppliermodule_test.DoNothing" -> "data.clientmodule_test.Ancestor" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="cls_member", style="solid"];
+"data.suppliermodule_test.DoNothing" -> "data.clientmodule_test.Specialization" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="relation", style="solid"];
+"data.suppliermodule_test.DoNothing2" -> "data.clientmodule_test.Specialization" [arrowhead="diamond", arrowtail="none", fontcolor="green", label="relation2", style="solid"];
 }
diff --git a/tests/data/classes_No_Name.vcg b/tests/data/classes_No_Name.vcg
new file mode 100644
index 000000000..1bf83e338
--- /dev/null
+++ b/tests/data/classes_No_Name.vcg
@@ -0,0 +1,46 @@
+graph:{
+  title:"classes_No_Name"
+  layoutalgorithm:dfs
+  late_edge_labels:yes
+  port_sharing:no
+  manhattan_edges:yes
+  node: {title:"data.clientmodule_test.Ancestor"  label:"\fbAncestor\fn\n\f____________\n\f08attr : str\n\f08cls_member\n\f____________\n\f10get_value()\n\f10set_value()"
+  shape:box
+}
+  node: {title:"data.suppliermodule_test.DoNothing"  label:"\fbDoNothing\fn\n\f___________"
+  shape:box
+}
+  node: {title:"data.suppliermodule_test.DoNothing2"  label:"\fbDoNothing2\fn\n\f____________"
+  shape:box
+}
+  node: {title:"data.suppliermodule_test.Interface"  label:"\fbInterface\fn\n\f___________\n\f10get_value()\n\f10set_value()"
+  shape:box
+}
+  node: {title:"data.clientmodule_test.Specialization"  label:"\fbSpecialization\fn\n\f________________\n\f08TYPE : str\n\f08relation\n\f08relation2\n\f08top : str\n\f________________"
+  shape:box
+}
+  edge: {sourcename:"data.clientmodule_test.Specialization" targetname:"data.clientmodule_test.Ancestor"  arrowstyle:solid
+  backarrowstyle:none
+  backarrowsize:10
+}
+  edge: {sourcename:"data.clientmodule_test.Ancestor" targetname:"data.suppliermodule_test.Interface"  arrowstyle:solid
+  backarrowstyle:none
+  linestyle:dotted
+  backarrowsize:10
+}
+  edge: {sourcename:"data.suppliermodule_test.DoNothing" targetname:"data.clientmodule_test.Ancestor"  arrowstyle:solid
+  backarrowstyle:none
+  textcolor:green
+  label:"cls_member"
+}
+  edge: {sourcename:"data.suppliermodule_test.DoNothing" targetname:"data.clientmodule_test.Specialization"  arrowstyle:solid
+  backarrowstyle:none
+  textcolor:green
+  label:"relation"
+}
+  edge: {sourcename:"data.suppliermodule_test.DoNothing2" targetname:"data.clientmodule_test.Specialization"  arrowstyle:solid
+  backarrowstyle:none
+  textcolor:green
+  label:"relation2"
+}
+}
diff --git a/tests/data/packages_No_Name.dot b/tests/data/packages_No_Name.dot
index 1ceeb7242..7b145dc91 100644
--- a/tests/data/packages_No_Name.dot
+++ b/tests/data/packages_No_Name.dot
@@ -1,8 +1,8 @@
 digraph "packages_No_Name" {
-charset="utf-8"
 rankdir=BT
-"0" [label="data", shape="box"];
-"1" [label="data.clientmodule_test", shape="box"];
-"2" [label="data.suppliermodule_test", shape="box"];
-"1" -> "2" [arrowhead="open", arrowtail="none"];
+charset="utf-8"
+"data" [color="black", label="data", shape="box", style="solid"];
+"data.clientmodule_test" [color="black", label="data.clientmodule_test", shape="box", style="solid"];
+"data.suppliermodule_test" [color="black", label="data.suppliermodule_test", shape="box", style="solid"];
+"data.clientmodule_test" -> "data.suppliermodule_test" [arrowhead="open", arrowtail="none"];
 }
diff --git a/tests/data/packages_No_Name.vcg b/tests/data/packages_No_Name.vcg
new file mode 100644
index 000000000..03f4e2481
--- /dev/null
+++ b/tests/data/packages_No_Name.vcg
@@ -0,0 +1,20 @@
+graph:{
+  title:"packages_No_Name"
+  layoutalgorithm:dfs
+  late_edge_labels:yes
+  port_sharing:no
+  manhattan_edges:yes
+  node: {title:"data"  label:"\fbdata\fn"
+  shape:box
+}
+  node: {title:"data.clientmodule_test"  label:"\fbdata.clientmodule_test\fn"
+  shape:box
+}
+  node: {title:"data.suppliermodule_test"  label:"\fbdata.suppliermodule_test\fn"
+  shape:box
+}
+  edge: {sourcename:"data.clientmodule_test" targetname:"data.suppliermodule_test"  arrowstyle:solid
+  backarrowstyle:none
+  backarrowsize:0
+}
+}