summaryrefslogtreecommitdiff
path: root/tests/message
diff options
context:
space:
mode:
authorPierre Sassoulas <pierre.sassoulas@gmail.com>2019-08-10 13:10:00 +0200
committerClaudiu Popa <pcmanticore@gmail.com>2019-08-19 13:54:52 +0200
commit672def32e3aca52da9be5d71566e1b86810b4283 (patch)
treee0ac92ee50b4113cb1a104a9e64c2c27565c359d /tests/message
parent4bd00376f84b673e397a1abe629d330a0444af35 (diff)
downloadpylint-git-672def32e3aca52da9be5d71566e1b86810b4283.tar.gz
[pylint.message] Create a MessageDefinition.check_msgid function
Diffstat (limited to 'tests/message')
-rw-r--r--tests/message/unittest_message.py13
-rw-r--r--tests/message/unittest_message_definition.py19
2 files changed, 19 insertions, 13 deletions
diff --git a/tests/message/unittest_message.py b/tests/message/unittest_message.py
index 3bc1578b5..d11eb3681 100644
--- a/tests/message/unittest_message.py
+++ b/tests/message/unittest_message.py
@@ -141,16 +141,3 @@ def test_register_error_new_id_duplicate_of_new(store):
{"W1234": ("message two", "msg-symbol-two", "another msg description.")},
"Message id 'W1234' cannot have both 'msg-symbol-one' and 'msg-symbol-two' as symbolic name.",
)
-
-
-@pytest.mark.parametrize(
- "msgid,expected",
- [
- ("Q1234", "Bad message type Q in 'Q1234'"),
- ("W12345", "Invalid message id 'W12345'"),
- ],
-)
-def test_create_invalid_message_type(msgid, expected):
- with pytest.raises(InvalidMessageError) as cm:
- MessageDefinition("checker", msgid, "msg", "descr", "symbol", "scope")
- assert str(cm.value) == expected
diff --git a/tests/message/unittest_message_definition.py b/tests/message/unittest_message_definition.py
index 0b9b05907..13ec7adae 100644
--- a/tests/message/unittest_message_definition.py
+++ b/tests/message/unittest_message_definition.py
@@ -5,11 +5,30 @@
import sys
+import pytest
+
from pylint.checkers import BaseChecker
from pylint.constants import WarningScope
+from pylint.exceptions import InvalidMessageError
from pylint.message import MessageDefinition
+@pytest.mark.parametrize(
+ "msgid,expected",
+ [
+ ("Q1234", "Bad message type Q in 'Q1234'"),
+ ("W12345", "Invalid message id 'W12345'"),
+ ],
+)
+def test_create_invalid_message_type(msgid, expected):
+ with pytest.raises(InvalidMessageError) as invalid_message_error:
+ MessageDefinition.check_msgid(msgid)
+ with pytest.raises(InvalidMessageError) as other_invalid_message_error:
+ MessageDefinition("checker", msgid, "msg", "descr", "symbol", "scope")
+ assert str(invalid_message_error.value) == expected
+ assert str(other_invalid_message_error.value) == expected
+
+
class FalseChecker(BaseChecker):
name = "FalseChecker"
msgs = {