diff options
| author | Jacob Walls <jacobtylerwalls@gmail.com> | 2023-02-11 11:02:27 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-11 17:02:27 +0100 |
| commit | a0b28f9019fabddd8ef428be75659082377abb4c (patch) | |
| tree | f720a642977c85443b67888f76b27945557ef76e /tests | |
| parent | bd22f2822f9344487357c90e18a8505705c60a29 (diff) | |
| download | pylint-git-a0b28f9019fabddd8ef428be75659082377abb4c.tar.gz | |
Fix FP for used-before-assignment with assignment expressions in containers (#8253)
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/functional/u/undefined/undefined_variable_py38.py | 10 | ||||
| -rw-r--r-- | tests/functional/u/undefined/undefined_variable_py38.txt | 5 |
2 files changed, 9 insertions, 6 deletions
diff --git a/tests/functional/u/undefined/undefined_variable_py38.py b/tests/functional/u/undefined/undefined_variable_py38.py index ef774e53a..6fb543e80 100644 --- a/tests/functional/u/undefined/undefined_variable_py38.py +++ b/tests/functional/u/undefined/undefined_variable_py38.py @@ -173,9 +173,13 @@ def expression_in_ternary_operator_inside_container_tuple(): return [(val3, val3) if (val3 := 'something') else 'anything'] -def expression_in_ternary_operator_inside_container_wrong_position(): - """2-element list where named expression comes too late""" - return [val3, val3 if (val3 := 'something') else 'anything'] # [used-before-assignment] +def expression_in_ternary_operator_inside_container_later_position(): + """ + Named expression follows unrelated item in container. + + If 23 is replaced with `val3`, there is currently a false negative, + but the false positive here is more important and likely to occur.""" + return [23, val3 if (val3 := 'something') else 'anything'] # Self-referencing diff --git a/tests/functional/u/undefined/undefined_variable_py38.txt b/tests/functional/u/undefined/undefined_variable_py38.txt index 832d8dd11..1674707a5 100644 --- a/tests/functional/u/undefined/undefined_variable_py38.txt +++ b/tests/functional/u/undefined/undefined_variable_py38.txt @@ -6,6 +6,5 @@ undefined-variable:83:6:83:19::Undefined variable 'else_assign_1':INFERENCE undefined-variable:106:6:106:19::Undefined variable 'else_assign_2':INFERENCE used-before-assignment:141:10:141:16:type_annotation_used_improperly_after_comprehension:Using variable 'my_int' before assignment:HIGH used-before-assignment:148:10:148:16:type_annotation_used_improperly_after_comprehension_2:Using variable 'my_int' before assignment:HIGH -used-before-assignment:178:12:178:16:expression_in_ternary_operator_inside_container_wrong_position:Using variable 'val3' before assignment:HIGH -used-before-assignment:182:9:182:10::Using variable 'z' before assignment:HIGH -used-before-assignment:189:6:189:19::Using variable 'NEVER_DEFINED' before assignment:CONTROL_FLOW +used-before-assignment:186:9:186:10::Using variable 'z' before assignment:HIGH +used-before-assignment:193:6:193:19::Using variable 'NEVER_DEFINED' before assignment:CONTROL_FLOW |