Fix checking of ``confidence`` in the unittests (#5376)

* Fix checking of ``confidence`` in the unittests

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

4 files changed, 77 insertions, 24 deletions

diff --git a/tests/checkers/unittest_base.py b/tests/checkers/unittest_base.py
index 46a9913a4..eeef6aaf7 100644
--- a/tests/checkers/unittest_base.py
+++ b/tests/checkers/unittest_base.py
@@ -35,6 +35,7 @@ from typing import Dict, Type
 import astroid
 
 from pylint.checkers import base
+from pylint.interfaces import HIGH, INFERENCE
 from pylint.testutils import CheckerTestCase, MessageTest, set_config
 
 
@@ -43,7 +44,7 @@ class TestDocstring(CheckerTestCase):
 
     def test_missing_docstring_module(self) -> None:
         module = astroid.parse("something")
-        message = MessageTest("missing-module-docstring", node=module)
+        message = MessageTest("missing-module-docstring", node=module, confidence=HIGH)
         with self.assertAddsMessages(message):
             self.checker.visit_module(module)
 
@@ -54,7 +55,9 @@ class TestDocstring(CheckerTestCase):
 
     def test_empty_docstring_module(self) -> None:
         module = astroid.parse("''''''")
-        message = MessageTest("empty-docstring", node=module, args=("module",))
+        message = MessageTest(
+            "empty-docstring", node=module, args=("module",), confidence=HIGH
+        )
         with self.assertAddsMessages(message):
             self.checker.visit_module(module)
 
@@ -69,7 +72,9 @@ class TestDocstring(CheckerTestCase):
                 '''
         """
         )
-        message = MessageTest("empty-docstring", node=node.body[0], args=("method",))
+        message = MessageTest(
+            "empty-docstring", node=node.body[0], args=("method",), confidence=INFERENCE
+        )
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(node.body[0])
 
@@ -79,7 +84,7 @@ class TestDocstring(CheckerTestCase):
         def func(tion):
            pass"""
         )
-        message = MessageTest("missing-function-docstring", node=func)
+        message = MessageTest("missing-function-docstring", node=func, confidence=HIGH)
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(func)
 
@@ -102,7 +107,7 @@ class TestDocstring(CheckerTestCase):
             pass
            """
         )
-        message = MessageTest("missing-function-docstring", node=func)
+        message = MessageTest("missing-function-docstring", node=func, confidence=HIGH)
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(func)
 
@@ -117,7 +122,7 @@ class TestDocstring(CheckerTestCase):
                 pass
            """
         )
-        message = MessageTest("missing-function-docstring", node=func)
+        message = MessageTest("missing-function-docstring", node=func, confidence=HIGH)
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(func)
 
@@ -141,7 +146,9 @@ class TestDocstring(CheckerTestCase):
                 pass
         """
         )
-        message = MessageTest("missing-function-docstring", node=node.body[0])
+        message = MessageTest(
+            "missing-function-docstring", node=node.body[0], confidence=INFERENCE
+        )
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(node.body[0])
 
@@ -158,7 +165,11 @@ class TestDocstring(CheckerTestCase):
                 return True
         """
         )
-        message = MessageTest("missing-function-docstring", node=module.body[1].body[0])
+        message = MessageTest(
+            "missing-function-docstring",
+            node=module.body[1].body[0],
+            confidence=INFERENCE,
+        )
         with self.assertAddsMessages(message):
             self.checker.visit_functiondef(module.body[1].body[0])
 
@@ -168,7 +179,7 @@ class TestDocstring(CheckerTestCase):
         class Klass(object):
            pass"""
         )
-        message = MessageTest("missing-class-docstring", node=klass)
+        message = MessageTest("missing-class-docstring", node=klass, confidence=HIGH)
         with self.assertAddsMessages(message):
             self.checker.visit_classdef(klass)
 
@@ -232,6 +243,7 @@ class TestNameChecker(CheckerTestCase):
                 "invalid-name",
                 node=methods[1],
                 args=("Attribute", "bar", "'[A-Z]+' pattern"),
+                confidence=INFERENCE,
             )
         ):
             self.checker.visit_functiondef(methods[1])
@@ -310,6 +322,8 @@ class TestNameChecker(CheckerTestCase):
                 msg_id="assign-to-new-keyword",
                 node=ast[0].targets[0],
                 args=("async", "3.7"),
+                confidence=HIGH,
+                col_offset=None,
             )
         ):
             self.checker.visit_assignname(ast[0].targets[0])
@@ -318,18 +332,28 @@ class TestNameChecker(CheckerTestCase):
                 msg_id="assign-to-new-keyword",
                 node=ast[1].targets[0],
                 args=("await", "3.7"),
+                confidence=HIGH,
+                col_offset=None,
             )
         ):
             self.checker.visit_assignname(ast[1].targets[0])
         with self.assertAddsMessages(
             MessageTest(
-                msg_id="assign-to-new-keyword", node=ast[2], args=("async", "3.7")
+                msg_id="assign-to-new-keyword",
+                node=ast[2],
+                args=("async", "3.7"),
+                confidence=HIGH,
+                col_offset=None,
             )
         ):
             self.checker.visit_functiondef(ast[2])
         with self.assertAddsMessages(
             MessageTest(
-                msg_id="assign-to-new-keyword", node=ast[3], args=("async", "3.7")
+                msg_id="assign-to-new-keyword",
+                node=ast[3],
+                args=("async", "3.7"),
+                confidence=HIGH,
+                col_offset=None,
             )
         ):
             self.checker.visit_classdef(ast[3])
@@ -360,6 +384,7 @@ class TestMultiNamingStyle(CheckerTestCase):
                 "classb",
                 "the `UP` group in the '(?:(?P<UP>[A-Z]+)|(?P<down>[a-z]+))$' pattern",
             ),
+            confidence=HIGH,
         )
         with self.assertAddsMessages(message):
             cls = None
@@ -389,6 +414,7 @@ class TestMultiNamingStyle(CheckerTestCase):
                     "class_a",
                     "'(?:(?P<UP>[A-Z]+)|(?P<down>[a-z]+))$' pattern",
                 ),
+                confidence=HIGH,
             ),
             MessageTest(
                 "invalid-name",
@@ -398,6 +424,7 @@ class TestMultiNamingStyle(CheckerTestCase):
                     "CLASSC",
                     "the `down` group in the '(?:(?P<UP>[A-Z]+)|(?P<down>[a-z]+))$' pattern",
                 ),
+                confidence=HIGH,
             ),
         ]
         with self.assertAddsMessages(*messages):
@@ -432,6 +459,7 @@ class TestMultiNamingStyle(CheckerTestCase):
                 "FUNC",
                 "the `down` group in the '(?:(?P<UP>[A-Z]+)|(?P<down>[a-z]+))$' pattern",
             ),
+            confidence=HIGH,
         )
         with self.assertAddsMessages(message):
             func = None
@@ -464,6 +492,7 @@ class TestMultiNamingStyle(CheckerTestCase):
                 "UPPER",
                 "the `down` group in the '(?:(?P<ignore>FOO)|(?P<UP>[A-Z]+)|(?P<down>[a-z]+))$' pattern",
             ),
+            confidence=HIGH,
         )
         with self.assertAddsMessages(message):
             func = None
diff --git a/tests/checkers/unittest_misc.py b/tests/checkers/unittest_misc.py
index df639cadb..23e19a9d0 100644
--- a/tests/checkers/unittest_misc.py
+++ b/tests/checkers/unittest_misc.py
@@ -30,7 +30,7 @@ class TestFixme(CheckerTestCase):
                 # FIXME message
                 """
         with self.assertAddsMessages(
-            MessageTest(msg_id="fixme", line=2, args="FIXME message")
+            MessageTest(msg_id="fixme", line=2, args="FIXME message", col_offset=17)
         ):
             self.checker.process_tokens(_tokenize_str(code))
 
@@ -38,14 +38,18 @@ class TestFixme(CheckerTestCase):
         code = """a = 1
                 # TODO
                 """
-        with self.assertAddsMessages(MessageTest(msg_id="fixme", line=2, args="TODO")):
+        with self.assertAddsMessages(
+            MessageTest(msg_id="fixme", line=2, args="TODO", col_offset=17)
+        ):
             self.checker.process_tokens(_tokenize_str(code))
 
     def test_xxx_without_space(self) -> None:
         code = """a = 1
                 #XXX
                 """
-        with self.assertAddsMessages(MessageTest(msg_id="fixme", line=2, args="XXX")):
+        with self.assertAddsMessages(
+            MessageTest(msg_id="fixme", line=2, args="XXX", col_offset=17)
+        ):
             self.checker.process_tokens(_tokenize_str(code))
 
     def test_xxx_middle(self) -> None:
@@ -59,7 +63,9 @@ class TestFixme(CheckerTestCase):
         code = """a = 1
                 #FIXME
                 """
-        with self.assertAddsMessages(MessageTest(msg_id="fixme", line=2, args="FIXME")):
+        with self.assertAddsMessages(
+            MessageTest(msg_id="fixme", line=2, args="FIXME", col_offset=17)
+        ):
             self.checker.process_tokens(_tokenize_str(code))
 
     @set_config(notes=[])
@@ -79,7 +85,7 @@ class TestFixme(CheckerTestCase):
                 # FIXME
                 """
         with self.assertAddsMessages(
-            MessageTest(msg_id="fixme", line=2, args="CODETAG")
+            MessageTest(msg_id="fixme", line=2, args="CODETAG", col_offset=17)
         ):
             self.checker.process_tokens(_tokenize_str(code))
 
@@ -92,7 +98,10 @@ class TestFixme(CheckerTestCase):
         code = "# TODO this should not trigger a fixme"
         with self.assertAddsMessages(
             MessageTest(
-                msg_id="fixme", line=1, args="TODO this should not trigger a fixme"
+                msg_id="fixme",
+                line=1,
+                args="TODO this should not trigger a fixme",
+                col_offset=1,
             )
         ):
             self.checker.process_tokens(_tokenize_str(code))
diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py
index 086f60d7f..f378fc402 100644
--- a/tests/checkers/unittest_typecheck.py
+++ b/tests/checkers/unittest_typecheck.py
@@ -29,7 +29,7 @@ import astroid
 import pytest
 
 from pylint.checkers import typecheck
-from pylint.interfaces import UNDEFINED
+from pylint.interfaces import INFERENCE, UNDEFINED
 from pylint.testutils import CheckerTestCase, MessageTest, set_config
 
 try:
@@ -63,6 +63,7 @@ class TestTypeChecker(CheckerTestCase):
                 "no-member",
                 node=node,
                 args=("Module", "optparse", "THIS_does_not_EXIST", ""),
+                confidence=INFERENCE,
             )
         ):
             self.checker.visit_attribute(node)
@@ -91,7 +92,10 @@ class TestTypeChecker(CheckerTestCase):
         """
         )
         message = MessageTest(
-            "no-member", node=node, args=("Module", "xml.etree", "Lala", "")
+            "no-member",
+            node=node,
+            args=("Module", "xml.etree", "Lala", ""),
+            confidence=INFERENCE,
         )
         with self.assertAddsMessages(message):
             self.checker.visit_attribute(node)
@@ -128,7 +132,10 @@ class TestTypeChecker(CheckerTestCase):
         """
         )
         message = MessageTest(
-            "no-member", node=node, args=("Module", "xml.etree.ElementTree", "Test", "")
+            "no-member",
+            node=node,
+            args=("Module", "xml.etree.ElementTree", "Test", ""),
+            confidence=INFERENCE,
         )
         with self.assertAddsMessages(message):
             self.checker.visit_attribute(node)
@@ -167,7 +174,10 @@ class TestTypeChecker(CheckerTestCase):
         """
         )
         message = MessageTest(
-            "no-member", node=node, args=("Module", "coverage.tracer", "CTracer", "")
+            "no-member",
+            node=node,
+            args=("Module", "coverage.tracer", "CTracer", ""),
+            confidence=INFERENCE,
         )
         with self.assertAddsMessages(message):
             self.checker.visit_attribute(node)
@@ -185,6 +195,7 @@ class TestTypeChecker(CheckerTestCase):
             "c-extension-no-member",
             node=node,
             args=("Module", "coverage.tracer", "CTracer", ""),
+            confidence=INFERENCE,
         )
         with self.assertAddsMessages(message):
             self.checker.visit_attribute(node)
diff --git a/tests/checkers/unittest_variables.py b/tests/checkers/unittest_variables.py
index 94f524f77..9b77e1705 100644
--- a/tests/checkers/unittest_variables.py
+++ b/tests/checkers/unittest_variables.py
@@ -30,7 +30,7 @@ import astroid
 
 from pylint.checkers import variables
 from pylint.constants import IS_PYPY
-from pylint.interfaces import UNDEFINED
+from pylint.interfaces import HIGH, UNDEFINED
 from pylint.testutils import CheckerTestCase, MessageTest, linter, set_config
 
 REGR_DATA_DIR = str(Path(__file__).parent / ".." / "regrtest_data")
@@ -256,7 +256,9 @@ class TestVariablesCheckerWithTearDown(CheckerTestCase):
         """
         )
         with self.assertAddsMessages(
-            MessageTest("unused-argument", node=node["abc"], args="abc")
+            MessageTest(
+                "unused-argument", node=node["abc"], args="abc", confidence=HIGH
+            )
         ):
             self.checker.visit_functiondef(node)
             self.checker.leave_functiondef(node)
@@ -268,7 +270,9 @@ class TestVariablesCheckerWithTearDown(CheckerTestCase):
         """
         )
         with self.assertAddsMessages(
-            MessageTest("unused-argument", node=node["abc"], args="abc")
+            MessageTest(
+                "unused-argument", node=node["abc"], args="abc", confidence=HIGH
+            )
         ):
             self.checker.visit_functiondef(node)
             self.checker.leave_functiondef(node)