diff options
| author | github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> | 2023-03-28 22:21:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-28 22:21:59 +0200 |
| commit | d429822d56c392b4be914f94d55807b55efbd705 (patch) | |
| tree | 9186dc4926ed5c65b10e9c7bb1fa5fc6a30c0275 /tests | |
| parent | ebf1952eb5b4bac46751d91181a62bea4bd6599f (diff) | |
| download | pylint-git-d429822d56c392b4be914f94d55807b55efbd705.tar.gz | |
Fix `unnecessary-lambda` false positive for lambdas using its parameters in their body (#8498) (#8506)
Fixes #8496
(cherry picked from commit b62143611a4713e4729ce9ecb6398f5f94d82f1a)
Co-authored-by: cherryblossom <31467609+cherryblossom000@users.noreply.github.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/functional/u/unnecessary/unnecessary_lambda.py | 11 | ||||
| -rw-r--r-- | tests/functional/u/unnecessary/unnecessary_lambda.txt | 2 |
2 files changed, 13 insertions, 0 deletions
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda.py b/tests/functional/u/unnecessary/unnecessary_lambda.py index 3e5ece2b1..82571a444 100644 --- a/tests/functional/u/unnecessary/unnecessary_lambda.py +++ b/tests/functional/u/unnecessary/unnecessary_lambda.py @@ -24,6 +24,12 @@ _ = lambda *args, **kwargs: _ANYARGS(*args, **kwargs) # +1: [unnecessary-lambda]
_ = lambda x, y, z, *args, **kwargs: _ANYARGS(x, y, z, *args, **kwargs)
+# These don't use their parameters in their body
+# +1: [unnecessary-lambda]
+_ = lambda x: z(lambda x: x)(x)
+# +1: [unnecessary-lambda]
+_ = lambda x, y: z(lambda x, y: x + y)(x, y)
+
# Lambdas that are *not* unnecessary and should *not* trigger warnings.
_ = lambda x: x
_ = lambda x: x()
@@ -50,3 +56,8 @@ _ = lambda: _ANYARGS(func=42) _ = lambda: code().analysis()
_ = lambda **kwargs: dict(bar=42, **kwargs)
+
+# These use the lambda parameters in their body
+_ = lambda x: x(x)
+_ = lambda x, y: x(x, y)
+_ = lambda x: z(lambda y: x + y)(x)
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda.txt b/tests/functional/u/unnecessary/unnecessary_lambda.txt index 1cfb149df..87f80872c 100644 --- a/tests/functional/u/unnecessary/unnecessary_lambda.txt +++ b/tests/functional/u/unnecessary/unnecessary_lambda.txt @@ -5,3 +5,5 @@ unnecessary-lambda:19:4:19:33:<lambda>:Lambda may not be necessary:UNDEFINED unnecessary-lambda:21:4:21:39:<lambda>:Lambda may not be necessary:UNDEFINED unnecessary-lambda:23:4:23:53:<lambda>:Lambda may not be necessary:UNDEFINED unnecessary-lambda:25:4:25:71:<lambda>:Lambda may not be necessary:UNDEFINED +unnecessary-lambda:29:4:29:31:<lambda>:Lambda may not be necessary:UNDEFINED +unnecessary-lambda:31:4:31:44:<lambda>:Lambda may not be necessary:UNDEFINED |