blob: 83046ce383a2bf19bc0f478af7f4105ffb78e101 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
|
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/pylint-dev/pylint/blob/main/LICENSE
# Copyright (c) https://github.com/pylint-dev/pylint/blob/main/CONTRIBUTORS.txt
"""Check for if / assign blocks that can be rewritten with if-expressions."""
from __future__ import annotations
from typing import TYPE_CHECKING
from astroid import nodes
from pylint.checkers import BaseChecker
if TYPE_CHECKING:
from pylint.lint import PyLinter
class ConsiderTernaryExpressionChecker(BaseChecker):
name = "consider_ternary_expression"
msgs = {
"W0160": (
"Consider rewriting as a ternary expression",
"consider-ternary-expression",
"Multiple assign statements spread across if/else blocks can be "
"rewritten with a single assignment and ternary expression",
)
}
def visit_if(self, node: nodes.If) -> None:
if isinstance(node.parent, nodes.If):
return
if len(node.body) != 1 or len(node.orelse) != 1:
return
bst = node.body[0]
ost = node.orelse[0]
if not isinstance(bst, nodes.Assign) or not isinstance(ost, nodes.Assign):
return
for bname, oname in zip(bst.targets, ost.targets):
if not isinstance(bname, nodes.AssignName) or not isinstance(
oname, nodes.AssignName
):
return
if bname.name != oname.name:
return
self.add_message("consider-ternary-expression", node=node)
def register(linter: PyLinter) -> None:
linter.register_checker(ConsiderTernaryExpressionChecker(linter))
|
