1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
# -*- coding: utf-8 -*-
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/PyCQA/pylint/blob/master/COPYING
import pytest
from pylint.checkers import BaseChecker
from pylint.exceptions import InvalidMessageError
from pylint.message import MessageDefinition, MessagesStore
@pytest.fixture
def store():
return MessagesStore()
@pytest.mark.parametrize(
"messages,expected",
[
(
{
"W1234": ("message one", "msg-symbol-one", "msg description"),
"W4321": ("message two", "msg-symbol-two", "msg description"),
},
r"Inconsistent checker part in message id 'W4321' (expected 'x12xx' because we already had ['W1234']).",
),
(
{
"W1233": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1234", "old-symbol")]},
),
"W1234": ("message one", "msg-symbol-one", "msg description"),
},
"Message id 'W1234' cannot have both 'msg-symbol-one' and 'old-symbol' as symbolic name.",
),
(
{
"W1234": ("message one", "msg-symbol-one", "msg description"),
"W1235": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1234", "old-symbol")]},
),
},
"Message id 'W1234' cannot have both 'msg-symbol-one' and 'old-symbol' as symbolic name.",
),
(
{
"W1234": (
"message one",
"msg-symbol-one",
"msg description",
{"old_names": [("W1201", "old-symbol-one")]},
),
"W1235": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1201", "old-symbol-two")]},
),
},
"Message id 'W1201' cannot have both 'old-symbol-one' and 'old-symbol-two' as symbolic name.",
),
(
{
"W1234": ("message one", "msg-symbol", "msg description"),
"W1235": ("message two", "msg-symbol", "msg description"),
},
"Message symbol 'msg-symbol' cannot be used for 'W1234' and 'W1235' at the same time.",
),
(
{
"W1233": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1230", "msg-symbol-one")]},
),
"W1234": ("message one", "msg-symbol-one", "msg description"),
},
"Message symbol 'msg-symbol-one' cannot be used for 'W1230' and 'W1234' at the same time.",
),
(
{
"W1234": ("message one", "msg-symbol-one", "msg description"),
"W1235": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1230", "msg-symbol-one")]},
),
},
"Message symbol 'msg-symbol-one' cannot be used for 'W1234' and 'W1235' at the same time.",
),
(
{
"W1234": (
"message one",
"msg-symbol-one",
"msg description",
{"old_names": [("W1230", "old-symbol-one")]},
),
"W1235": (
"message two",
"msg-symbol-two",
"msg description",
{"old_names": [("W1231", "old-symbol-one")]},
),
},
"Message symbol 'old-symbol-one' cannot be used for 'W1230' and 'W1235' at the same time.",
),
],
)
def test_register_error(store, messages, expected):
class Checker(BaseChecker):
name = "checker"
msgs = messages
with pytest.raises(InvalidMessageError) as cm:
store.register_messages_from_checker(Checker())
assert str(cm.value) == expected
def test_register_error_new_id_duplicate_of_new(store):
class CheckerOne(BaseChecker):
name = "checker_one"
msgs = {"W1234": ("message one", "msg-symbol-one", "msg description.")}
class CheckerTwo(BaseChecker):
name = "checker_two"
msgs = {"W1234": ("message two", "msg-symbol-two", "another msg description.")}
store.register_messages_from_checker(CheckerOne())
test_register_error(
store,
{"W1234": ("message two", "msg-symbol-two", "another msg description.")},
"Message id 'W1234' cannot have both 'msg-symbol-one' and 'msg-symbol-two' as symbolic name.",
)
@pytest.mark.parametrize(
"msgid,expected",
[
("Q1234", "Bad message type Q in 'Q1234'"),
("W12345", "Invalid message id 'W12345'"),
],
)
def test_create_invalid_message_type(msgid, expected):
with pytest.raises(InvalidMessageError) as cm:
MessageDefinition("checker", msgid, "msg", "descr", "symbol", "scope")
assert str(cm.value) == expected
|
