1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
|
"""Emit a message for iteration through range and len is encountered."""
# pylint: disable=missing-docstring, import-error, unsubscriptable-object, too-few-public-methods, unnecessary-list-index-lookup
def bad():
iterable = [1, 2, 3]
for obj in range(len(iterable)): # [consider-using-enumerate]
yield iterable[obj]
for obj in range(0, len(iterable)): # [consider-using-enumerate]
yield iterable[obj]
class Bad:
def __iter__(self):
iterable = [1, 2, 3]
for i in range(len(iterable)): # [consider-using-enumerate]
yield iterable[i]
def test(self):
for i in range(len(self)): # [consider-using-enumerate]
yield self[i]
def good():
iterable = other_obj = [1, 2, 3]
total = 0
for obj in range(len(iterable)):
total += obj
yield total
yield iterable[obj + 1: 2]
yield iterable[len(obj)]
for obj in iterable:
yield iterable[obj - 1]
for index, obj in enumerate(iterable):
yield iterable[index]
for index in range(0, 10):
yield iterable[index + 1]
for index in range(10):
yield iterable[index]
for index in range(len([1, 2, 3, 4])):
yield index
for index in range(1, len(iterable)):
yield index
for index in range(len(iterable)):
yield [1, 2, 3][index]
yield len([1, 2, 3])
for index in range(len(iterable)):
yield other_obj[index]
# pylint: disable=import-outside-toplevel
from unknown import unknown
for index in range(unknown(iterable)):
yield iterable[index]
for index in range(len(iterable)):
def test(iterable):
return iterable[index] # pylint: disable=cell-var-from-loop
yield test([1, 2, 3])
class Good:
def __iter__(self):
# Should not suggest enumerate on self
for i in range(len(self)):
yield self[i]
def does_not_crash_on_range_without_args():
for elem in range():
print(elem)
# False negative described in #3657
# https://github.com/PyCQA/pylint/issues/3657
class MyClass:
def __init__(self):
self.my_list = []
my_obj = MyClass()
def my_function(instance: MyClass):
for i in range(len(instance.my_list)): # [consider-using-enumerate]
var = instance.my_list[i]
print(var)
|
