1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
"""Functional test"""
# pylint: disable=missing-function-docstring, invalid-name
def any_even(items):
"""Return True if the list contains any even numbers"""
for item in items: # [consider-using-any-or-all]
if item % 2 == 0:
return True
return False
def all_even(items):
"""Return True if the list contains all even numbers"""
for item in items: # [consider-using-any-or-all]
if not item % 2 == 0:
return False
return True
def any_uneven(items):
"""Return True if the list contains any uneven numbers"""
for item in items: # [consider-using-any-or-all]
if not item % 2 == 0:
return True
return False
def all_uneven(items):
"""Return True if the list contains all uneven numbers"""
for item in items: # [consider-using-any-or-all]
if item % 2 == 0:
return False
return True
def is_from_string(item):
"""Return True if one of parents of item is a string"""
for parent in item.parents(): # [consider-using-any-or-all]
if isinstance(parent, str):
return True
return False
def is_not_from_string(item):
"""Return True if one of parents of item isn't a string"""
for parent in item.parents(): # [consider-using-any-or-all]
if not isinstance(parent, str):
return True
return False
def nested_check(items):
"""Tests that for loops at deeper levels are picked up"""
if items and len(items) > 5:
print(items)
for item in items: # [consider-using-any-or-all]
if item in (1, 2, 3):
return False
return True
print(items)
return items[3] > 5
def words_contains_word(words):
"""Return whether words contains 'word'"""
for word in words: # [consider-using-any-or-all]
if word == "word":
return True
return False
def complicated_condition_check(items):
"""Case where we expect not any statement with a more complicated condition"""
for item in items: # [consider-using-any-or-all]
if item % 2 == 0 and (item % 3 == 0 or item > 15):
return False
return True
def is_from_decorator1(node):
"""Case where we expect a particularly long message to be emitted."""
for ancestor in node: # [consider-using-any-or-all]
if (
ancestor.name in ("Exception", "BaseException")
and ancestor.root().name == "Exception"
):
return True
return False
def is_from_decorator2(items):
"""Case where we expect an all statement because of negation in the condition"""
for item in items: # [consider-using-any-or-all]
if not(item % 2 == 0 and (item % 3 == 0 or item > 15)):
return False
return True
def is_from_decorator3(node):
"""Case where we expect a not all statement because of negation in the condition"""
for ancestor in node: # [consider-using-any-or-all]
if not (
ancestor.name in ("Exception", "BaseException")
and ancestor.root().name == "Exception"
):
return True
return False
def no_suggestion_if_not_if():
"""Do not emit if the for loop does not have the pattern we are looking for"""
for val in range(1):
var = val
return var
def no_suggestion_if_not_bool(item):
"""Do not emit if the if-statement does not return a bool"""
for parent in item.parents():
if isinstance(parent, str):
return "True"
return "False"
def print_items(items):
"""Do not emit if there is no If condition in the for loop."""
for item in items:
print(item)
return True
def print_items2(items):
"""Do not emit if anything besides a boolean is returned."""
for item in items:
return item
return True
def print_items3(items):
"""Do not emit if anything besides a boolean is returned."""
for _ in items:
return False
return items
def print_items4(items):
"""Do not emit if there is more logic which can cause side effects
or become less readable in a list comprehension.
"""
for item in items:
if isinstance(item, str):
print(item)
return False
return True
def is_from_decorator(node):
"""Do not emit if the if has an else condition. Generally implies more complicated logic."""
for parent in node.node_ancestors():
if isinstance(parent, str): # pylint: disable=no-else-return
return True
else:
if parent in parent.selected_annotations:
return False
return False
def optimized_any_with_break(split_lines, max_chars):
"""False negative found in https://github.com/pylint-dev/pylint/pull/7697"""
potential_line_length_warning = False
for line in split_lines: # [consider-using-any-or-all]
if len(line) > max_chars:
potential_line_length_warning = True
break
return potential_line_length_warning
def optimized_any_without_break(split_lines, max_chars):
potential_line_length_warning = False
for line in split_lines: # [consider-using-any-or-all]
if len(line) > max_chars:
potential_line_length_warning = True
return potential_line_length_warning
def print_line_without_break(split_lines, max_chars):
potential_line_length_warning = False
for line in split_lines:
print(line)
if len(line) > max_chars:
potential_line_length_warning = True
return potential_line_length_warning
def print_line_without_reassign(split_lines, max_chars):
potential_line_length_warning = False
for line in split_lines:
if len(line) > max_chars:
print(line)
return potential_line_length_warning
def multiple_flags(split_lines, max_chars):
potential_line_length_warning = False
for line in split_lines:
if len(line) > max_chars:
num = 1
print(num)
potential_line_length_warning = True
return potential_line_length_warning
s = ["hi", "hello", "goodbye", None]
flag = True
for i, elem in enumerate(s):
if elem is None:
continue
cnt_s = cnt_t = 0
for j in range(i, len(s)):
if s[j] == elem:
cnt_s += 1
s[j] = None
Flag = False
def with_elif(split_lines, max_chars):
"""
Do not raise consider-using-any-or-all because the intent in this code
is to iterate over all the lines (not short-circuit) and see what
the last value would be.
"""
last_longest_line = False
for line in split_lines:
if len(line) > max_chars:
last_longest_line = True
elif len(line) == max_chars:
last_longest_line = False
return last_longest_line
def first_even(items):
"""Return first even number"""
for item in items:
if item % 2 == 0:
return item
return None
def even(items):
for item in items:
if item % 2 == 0:
return True
return None
def iterate_leaves(leaves, current_node):
results = []
current_node.was_checked = True
for leaf in leaves:
if isinstance(leaf, bool):
current_node.was_checked = False
else:
results.append(leaf)
return results
|
