1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
|
"""
Checks that primitive values are not used in an
iterating/mapping context.
"""
# pylint: disable=missing-docstring,invalid-name,too-few-public-methods,no-init,no-self-use,import-error,unused-argument,bad-mcs-method-argument,wrong-import-position,no-else-return, useless-object-inheritance, unnecessary-comprehension
from __future__ import print_function
# primitives
numbers = [1, 2, 3]
for i in numbers:
pass
for i in iter(numbers):
pass
for i in "123":
pass
for i in u"123":
pass
for i in b"123":
pass
for i in bytearray(b"123"):
pass
for i in set(numbers):
pass
for i in frozenset(numbers):
pass
for i in dict(a=1, b=2):
pass
# comprehensions
for i in [x for x in range(10)]:
pass
for i in {x for x in range(1, 100, 2)}:
pass
for i in {x: 10 - x for x in range(10)}:
pass
# generators
def powers_of_two():
k = 0
while k < 10:
yield 2 ** k
k += 1
for i in powers_of_two():
pass
for i in powers_of_two: # [not-an-iterable]
pass
# check for custom iterators
class A(object):
pass
class B(object):
def __iter__(self):
return self
def __next__(self):
return 1
def next(self):
return 1
class C(object):
"old-style iterator"
def __getitem__(self, k):
if k > 10:
raise IndexError
return k + 1
def __len__(self):
return 10
for i in C():
print(i)
def test(*args):
print(args)
test(*A()) # [not-an-iterable]
test(*B())
test(*B) # [not-an-iterable]
for i in A(): # [not-an-iterable]
pass
for i in B():
pass
for i in B: # [not-an-iterable]
pass
for i in range: # [not-an-iterable]
pass
# check that primitive non-iterable types are caught
for i in True: # [not-an-iterable]
pass
for i in None: # [not-an-iterable]
pass
for i in 8.5: # [not-an-iterable]
pass
for i in 10: # [not-an-iterable]
pass
# skip uninferable instances
from some_missing_module import Iterable
class MyClass(Iterable):
pass
m = MyClass()
for i in m:
print(i)
# skip checks if statement is inside mixin/base/abstract class
class ManagedAccessViewMixin(object):
access_requirements = None
def get_access_requirements(self):
return self.access_requirements
def dispatch(self, *_args, **_kwargs):
klasses = self.get_access_requirements()
# no error should be emitted here
for requirement in klasses:
print(requirement)
class BaseType(object):
valid_values = None
def validate(self, value):
if self.valid_values is None:
return True
else:
# error should not be emitted here
for v in self.valid_values:
if value == v:
return True
return False
class AbstractUrlMarkManager(object):
def __init__(self):
self._lineparser = None
self._init_lineparser()
# error should not be emitted here
for line in self._lineparser:
print(line)
def _init_lineparser(self):
raise NotImplementedError
# class is not named as abstract
# but still is deduceably abstract
class UrlMarkManager(object):
def __init__(self):
self._lineparser = None
self._init_lineparser()
# error should not be emitted here
for line in self._lineparser:
print(line)
def _init_lineparser(self):
raise NotImplementedError
class HasDynamicGetattr(object):
def __init__(self):
self._obj = []
def __getattr__(self, attr):
return getattr(self._obj, attr)
for elem in HasDynamicGetattr():
pass
|
