1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
|
# pylint: disable=missing-docstring,too-few-public-methods,wrong-import-position,use-dict-literal
# pylint: disable=wrong-import-order, undefined-variable
REVISION = None
REVISION() # [not-callable]
def correct():
return 1
REVISION = correct()
class Correct:
"""callable object"""
class MetaCorrect:
"""callable object"""
def __call__(self):
return self
INSTANCE = Correct()
CALLABLE_INSTANCE = MetaCorrect()
CORRECT = CALLABLE_INSTANCE()
INCORRECT = INSTANCE() # [not-callable]
LIST = []
INCORRECT = LIST() # [not-callable]
DICT = {}
INCORRECT = DICT() # [not-callable]
TUPLE = ()
INCORRECT = TUPLE() # [not-callable]
INT = 1
INCORRECT = INT() # [not-callable]
# Test calling properties. Pylint can detect when using only the
# getter, but it doesn't infer properly when having a getter
# and a setter.
class MyProperty(property):
""" test subclasses """
class PropertyTest:
""" class """
def __init__(self):
self.attr = 4
@property
def test(self):
""" Get the attribute """
return self.attr
@test.setter
def test(self, value):
""" Set the attribute """
self.attr = value
@MyProperty
def custom(self):
""" Get the attribute """
return self.attr
@custom.setter
def custom(self, value):
""" Set the attribute """
self.attr = value
PROP = PropertyTest()
PROP.test(40) # [not-callable]
PROP.custom() # [not-callable]
# Safe from not-callable when using properties.
class SafeProperty:
@property
def static(self):
return staticmethod
@property
def klass(self):
return classmethod
@property
def get_lambda(self):
return lambda: None
@property
def other_function(self):
def function(arg):
return arg
return function
@property
def dict_builtin(self):
return dict
@property
def range_builtin(self):
return range
@property
def instance(self):
class Empty:
def __call__(self):
return 42
return Empty()
@property
def does_not_make_sense(self):
raise NotImplementedError
PROP1 = SafeProperty()
PROP1.static(2)
PROP1.klass(2)
PROP1.get_lambda()
PROP1.other_function(4)
PROP1.dict_builtin()
PROP1.range_builtin(4)
PROP1.instance()
PROP1.does_not_make_sense()
import missing # pylint: disable=import-error
class UnknownBaseCallable(missing.Blah):
pass
UnknownBaseCallable()()
# Regression test for #4426
# If property is inferable we shouldn't double emit the message
# See: https://github.com/pylint-dev/pylint/issues/4426
class ClassWithProperty:
@property
def value(self):
return 42
CLASS_WITH_PROP = ClassWithProperty().value() # [not-callable]
# Test typing.Namedtuple is callable
# See: https://github.com/pylint-dev/pylint/issues/1295
import typing
Named = typing.NamedTuple("Named", [("foo", int), ("bar", int)])
named = Named(1, 2)
# NamedTuple is callable, even if it aliased to an attribute
# See https://github.com/pylint-dev/pylint/issues/1730
class TestNamedTuple:
def __init__(self, field: str) -> None:
self.my_tuple = typing.NamedTuple("Tuple", [(field, int)])
self.item: self.my_tuple
def set_item(self, item: int) -> None:
self.item = self.my_tuple(item)
# Test descriptor call
def func():
pass
class ADescriptor:
def __get__(self, instance, owner):
return func
class AggregateCls:
a = ADescriptor()
AggregateCls().a()
# Make sure not-callable isn't raised for descriptors
# astroid can't process descriptors correctly so
# pylint needs to ignore not-callable for them
# right now
# Test for https://github.com/pylint-dev/pylint/issues/1699
import multiprocessing
multiprocessing.current_process()
# Make sure not-callable isn't raised for uninferable properties
class MyClass:
@property
def call(self):
return undefined
a = A()
a.call()
# Make sure the callable check does not crash when a node's parent cannot be determined.
def get_number(arg):
return 2 * arg
get_number(10)() # [not-callable]
class Klass:
def __init__(self):
self._x = None
@property
def myproperty(self):
if self._x is None:
self._x = lambda: None
return self._x
myobject = Klass()
myobject.myproperty()
class Klass2:
@property
def something(self):
if __file__.startswith('s'):
return str
return 'abcd'
obj2 = Klass2()
obj2.something()
# Regression test for https://github.com/pylint-dev/pylint/issues/7109
instance_or_cls = MyClass # pylint:disable=invalid-name
instance_or_cls = MyClass()
if not isinstance(instance_or_cls, MyClass):
new = MyClass.__new__(instance_or_cls)
new()
# Regression test for https://github.com/pylint-dev/pylint/issues/5113.
# Do not emit `not-callable`.
ATTRIBUTES = {
'DOMAIN': ("domain", str),
'IMAGE': ("image", bytes),
}
for key, (name, validate) in ATTRIBUTES.items():
name = validate(1)
|
