blob: 6f8e048e4c86fdb4ec81823bc919da39e7371e50 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
"""used-before-assignment (E0601)"""
def function():
"""Consider that except blocks may not execute."""
try:
pass
except ValueError:
some_message = 'some message'
if not some_message: # [used-before-assignment]
return 1
return some_message
def uses_nonlocal():
"""https://github.com/PyCQA/pylint/issues/5965"""
count = 0
def inner():
nonlocal count
try:
print(count)
except ValueError:
count +=1
return inner()
def uses_unrelated_nonlocal():
"""Unrelated nonlocals still let messages emit"""
count = 0
unrelated = 0
def inner():
nonlocal unrelated
try:
print(count) # [used-before-assignment]
except ValueError:
count += 1
print(count)
return inner()
# Cases related to a specific control flow where
# the `else` of a loop can depend on a name only defined
# in a single except handler because that except handler is the
# only non-break exit branch.
def valid_only_non_break_exit_from_loop_is_except_handler():
"""https://github.com/PyCQA/pylint/issues/5683"""
for _ in range(3):
try:
function() # not an exit branch because of `else` below
except ValueError as verr:
error = verr # < exit branch where error is defined
else:
break # < exit condition where error is *not* defined
# will skip else: raise error
print("retrying...")
else:
# This usage is valid because there is only one exit branch
raise error
def invalid_no_outer_else():
"""The reliance on the name is not guarded by else."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
else:
break
print("retrying...")
raise error # [used-before-assignment]
def invalid_no_outer_else_2():
"""Same, but the raise is inside a loop."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
else:
break
raise error # [used-before-assignment]
def invalid_no_inner_else():
"""No inner else statement."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
print("retrying...")
if function():
break
else:
raise error # [used-before-assignment]
def invalid_wrong_break_location():
"""The break is in the wrong location."""
for _ in range(3):
try:
function()
break
except ValueError as verr:
error = verr
print("I give up")
else:
raise error # [used-before-assignment]
def invalid_no_break():
"""No break."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
else:
pass
else: # pylint: disable=useless-else-on-loop
raise error # [used-before-assignment]
def invalid_other_non_break_exit_from_loop_besides_except_handler():
"""The continue creates another exit branch."""
while function():
if function():
continue
try:
pass
except ValueError as verr:
error = verr
else:
break
else:
raise error # [used-before-assignment]
def valid_continue_does_not_matter():
"""This continue doesn't matter: still just one exit branch."""
while function():
try:
for _ in range(3):
if function():
continue
print(1 / 0)
except ZeroDivisionError as zde:
error = zde
else:
break
else:
raise error
def invalid_conditional_continue_after_break():
"""The continue is another exit branch"""
while function():
try:
if function():
break
if not function():
continue
except ValueError as verr:
error = verr
else:
break
else:
raise error # [used-before-assignment]
def invalid_unrelated_loops():
"""The loop else in question is not related to the try/except/else."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
else:
break
while function():
print('The time is:')
break
else:
raise error # [used-before-assignment]
def valid_nested_loops():
"""The name `error` is still available in a nested else."""
for _ in range(3):
try:
function()
except ValueError as verr:
error = verr
else:
break
else:
while function():
print('The time is:')
break
else:
raise error
|
