diff options
| author | Vlad Temian <vladtemian@gmail.com> | 2014-11-22 17:31:20 +0200 |
|---|---|---|
| committer | Vlad Temian <vladtemian@gmail.com> | 2014-11-22 17:31:20 +0200 |
| commit | 4f5f1a1c9c8de4907dc36d08c40470589aa43967 (patch) | |
| tree | fb724da146abf695ef21c947877c04bfaf99b416 | |
| parent | 2043a0e2b7ed5f80167db4644ef4bfb6f1d13e2b (diff) | |
| download | pylint-redundant-assert.tar.gz | |
Improve testsredundant-assert
| -rw-r--r-- | checkers/stdlib.py | 8 | ||||
| -rw-r--r-- | test/functional/redundant_unittest_assert.py | 5 | ||||
| -rw-r--r-- | test/functional/redundant_unittest_assert.txt | 1 |
3 files changed, 10 insertions, 4 deletions
diff --git a/checkers/stdlib.py b/checkers/stdlib.py index 81ea9f6..7dad6c9 100644 --- a/checkers/stdlib.py +++ b/checkers/stdlib.py @@ -57,7 +57,7 @@ class StdlibChecker(BaseChecker): 'should be emited.') } - @utils.check_messages('bad-open-mode', 'redundant-unitetest-assert') + @utils.check_messages('bad-open-mode', 'redundant-unittest-assert') def visit_callfunc(self, node): """Visit a CallFunc node.""" if hasattr(node, 'func'): @@ -88,9 +88,9 @@ class StdlibChecker(BaseChecker): self._check_datetime(value) def _check_redundant_assert(self, node, infer): - if (infer.name in ['assertTrue', 'assertFalse'] and - isinstance(infer, astroid.BoundMethod) and - isinstance(node.args[0], astroid.Const)): + if (isinstance(infer, astroid.BoundMethod) and + isinstance(node.args[0], astroid.Const) and + infer.name in ['assertTrue', 'assertFalse']): self.add_message('redundant-unittest-assert', args=(node.args[0].value, ), node=node) diff --git a/test/functional/redundant_unittest_assert.py b/test/functional/redundant_unittest_assert.py index a8f6740..85abd98 100644 --- a/test/functional/redundant_unittest_assert.py +++ b/test/functional/redundant_unittest_assert.py @@ -17,3 +17,8 @@ class Tests(unittest.TestCase): self.assertTrue('I meant assertEqual not assertTrue', some_var) # +1:[redundant-unittest-assert] self.assertFalse('I meant assertEqual not assertFalse', some_var) + # +1:[redundant-unittest-assert] + self.assertTrue(True, some_var) + + self.assertTrue('should be' in some_var, some_var) + self.assertTrue(some_var, some_var) diff --git a/test/functional/redundant_unittest_assert.txt b/test/functional/redundant_unittest_assert.txt index a79408f..cbe72e4 100644 --- a/test/functional/redundant_unittest_assert.txt +++ b/test/functional/redundant_unittest_assert.txt @@ -1,2 +1,3 @@ redundant-unittest-assert:17:Tests.test_something:"Redundant use of assertTrue or assertFalse with constant value 'I meant assertEqual not assertTrue'" redundant-unittest-assert:19:Tests.test_something:"Redundant use of assertTrue or assertFalse with constant value 'I meant assertEqual not assertFalse'" +redundant-unittest-assert:21:Tests.test_something:"Redundant use of assertTrue or assertFalse with constant value True" |