Add a new warning, 'using-constant-test'.

This new warning is emitted when a conditional statement (If, IfExp) uses a test
which is always constant, such as numbers, classes, functions etc.
This is most likely an error from the user's part. Closes issue #524.

9 files changed, 10 insertions, 10 deletions

diff --git a/pylint/test/input/func_block_disable_msg.py b/pylint/test/input/func_block_disable_msg.py
index eeb4eb1..f2ab2ca 100644
--- a/pylint/test/input/func_block_disable_msg.py
+++ b/pylint/test/input/func_block_disable_msg.py
@@ -90,7 +90,7 @@ class Foo(object):
         """test re-enabling right after a block with whitespace"""
         eris = 5
 
-        if eris:
+        if eris: # pylint: disable=using-constant-test
             print("In block")
 
         # pylint: disable=E1101
diff --git a/pylint/test/input/func_break_or_return_in_try_finally.py b/pylint/test/input/func_break_or_return_in_try_finally.py
index d9a50f9..f880926 100644
--- a/pylint/test/input/func_break_or_return_in_try_finally.py
+++ b/pylint/test/input/func_break_or_return_in_try_finally.py
@@ -1,7 +1,7 @@
 'Exeptions may be silently swallowed'
 from __future__ import print_function
 __revision__ = None
-
+# pylint: disable=using-constant-test
 def insidious_break_and_return():
     """I found you !"""
     for i in range(0, -5, -1):
diff --git a/pylint/test/input/func_continue_not_in_loop.py b/pylint/test/input/func_continue_not_in_loop.py
index 4186aa5..bdde320 100644
--- a/pylint/test/input/func_continue_not_in_loop.py
+++ b/pylint/test/input/func_continue_not_in_loop.py
@@ -1,5 +1,5 @@
 """this module produces a SyntaxError at execution time"""
-
+# pylint: disable=using-constant-test
 __revision__ = None
 
 def run():
diff --git a/pylint/test/input/func_noerror_no_warning_docstring.py b/pylint/test/input/func_noerror_no_warning_docstring.py
index f8ee9bc..bd30d7e 100644
--- a/pylint/test/input/func_noerror_no_warning_docstring.py
+++ b/pylint/test/input/func_noerror_no_warning_docstring.py
@@ -1,7 +1,7 @@
 ''' Test for inheritence '''
 from __future__ import print_function
 __revision__ = 1
-# pylint: disable=too-few-public-methods
+# pylint: disable=too-few-public-methods, using-constant-test
 class AAAA(object):
     ''' class AAAA '''
 
diff --git a/pylint/test/input/func_noerror_raise_return_self.py b/pylint/test/input/func_noerror_raise_return_self.py
index 2834c3c..36ce826 100644
--- a/pylint/test/input/func_noerror_raise_return_self.py
+++ b/pylint/test/input/func_noerror_raise_return_self.py
@@ -1,5 +1,5 @@
 """see ticket #5672"""
-# pylint: disable=R0903,W0232,C0111,C0103
+# pylint: disable=R0903,W0232,C0111,C0103,using-constant-test
 
 __revision__ = 0
 
diff --git a/pylint/test/input/func_return_yield_mix_py_33.py b/pylint/test/input/func_return_yield_mix_py_33.py
index 1a3cd5d..4054ebb 100644
--- a/pylint/test/input/func_return_yield_mix_py_33.py
+++ b/pylint/test/input/func_return_yield_mix_py_33.py
@@ -1,5 +1,5 @@
 """pylint should detect yield and return mix inside genrators"""
-__revision__ = None
+# pylint: disable=using-constant-test
 def somegen():
     """this is a bad generator"""
     if True:
diff --git a/pylint/test/input/func_w0405.py b/pylint/test/input/func_w0405.py
index 8071ab2..f1c1677 100644
--- a/pylint/test/input/func_w0405.py
+++ b/pylint/test/input/func_w0405.py
@@ -2,7 +2,7 @@
 """
 from __future__ import absolute_import, print_function
 __revision__ = 0
-
+# pylint: disable=using-constant-test
 import os
 from os.path import join, exists
 
@@ -23,7 +23,7 @@ def func(yooo):
     import re
     re.compile('.*')
 
-if 1:
+if 1: # pylint: disable=using-constant-test
     import sys
     print(sys.modules)
 else:
diff --git a/pylint/test/input/func_w0406.py b/pylint/test/input/func_w0406.py
index 6feff50..d45a6b5 100644
--- a/pylint/test/input/func_w0406.py
+++ b/pylint/test/input/func_w0406.py
@@ -1,5 +1,5 @@
 """test module importing itself"""
-# pylint: disable=no-absolute-import
+# pylint: disable=no-absolute-import,using-constant-test
 from __future__ import print_function
 __revision__ = 0
 
diff --git a/pylint/test/input/func_w0702.py b/pylint/test/input/func_w0702.py
index 1f82a23..800f4c1 100644
--- a/pylint/test/input/func_w0702.py
+++ b/pylint/test/input/func_w0702.py
@@ -2,7 +2,7 @@
 """
 from __future__ import print_function
 __revision__ = 0
-
+# pylint: disable=using-constant-test
 if __revision__:
     try:
         print(__revision__)