diff options
Diffstat (limited to 'checkers')
| -rw-r--r-- | checkers/classes.py | 12 | ||||
| -rw-r--r-- | checkers/stdlib.py | 2 |
2 files changed, 9 insertions, 5 deletions
diff --git a/checkers/classes.py b/checkers/classes.py index 7b216fe..1a10c35 100644 --- a/checkers/classes.py +++ b/checkers/classes.py @@ -179,11 +179,11 @@ MSGS = { 'missing-interface-method', 'Used when a method declared in an interface is missing from a \ class implementing this interface'), - 'W0221': ('Arguments number differs from %s method', + 'W0221': ('Arguments number differs from %s %r method', 'arguments-differ', 'Used when a method has a different number of arguments than in \ the implemented interface or in an overridden method.'), - 'W0222': ('Signature differs from %s method', + 'W0222': ('Signature differs from %s %r method', 'signature-differs', 'Used when a method signature is different than in the \ implemented interface or in an overridden method.'), @@ -939,9 +939,13 @@ a metaclass class method.'} if is_attr_private(method1.name): return if len(method1.args.args) != len(refmethod.args.args): - self.add_message('arguments-differ', args=class_type, node=method1) + self.add_message('arguments-differ', + args=(class_type, method1.name), + node=method1) elif len(method1.args.defaults) < len(refmethod.args.defaults): - self.add_message('signature-differs', args=class_type, node=method1) + self.add_message('signature-differs', + args=(class_type, method1.name), + node=method1) def is_first_attr(self, node): """Check that attribute lookup name use first attribute variable name diff --git a/checkers/stdlib.py b/checkers/stdlib.py index 216d640..b6b8026 100644 --- a/checkers/stdlib.py +++ b/checkers/stdlib.py @@ -134,7 +134,7 @@ class StdlibChecker(BaseChecker): def _check_redundant_assert(self, node, infer): if (isinstance(infer, astroid.BoundMethod) and - isinstance(node.args[0], astroid.Const) and + node.args and isinstance(node.args[0], astroid.Const) and infer.name in ['assertTrue', 'assertFalse']): self.add_message('redundant-unittest-assert', args=(infer.name, node.args[0].value, ), |