diff options
author | Jon Dufresne <jon.dufresne@gmail.com> | 2018-12-24 17:05:37 -0500 |
---|---|---|
committer | Jon Dufresne <jon.dufresne@gmail.com> | 2018-12-24 17:17:09 -0500 |
commit | df9b2d50b75ee42663195058f3112e6c440381c5 (patch) | |
tree | e7f9404d6d5675308f61e5f26acaaced6e66557f /unitTests.py | |
parent | 7ee59bf9bec777b5a3f627dc2cfbde637ce9ebfc (diff) | |
download | pyparsing-git-df9b2d50b75ee42663195058f3112e6c440381c5.tar.gz |
Replace bare 'except:' with 'except Exception;'
Catching all exceptions is generally considered a bad practice under
most circumstances as it will also catch KeyboardInterrupt and
SystemExit. These special cases should be raised to the interpreter to
allow the Python process to exit.
This fix complies with pycodestyle's error code E722:
https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes
> do not use bare except, specify exception instead
Diffstat (limited to 'unitTests.py')
-rw-r--r-- | unitTests.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/unitTests.py b/unitTests.py index 7dcc237..851a98a 100644 --- a/unitTests.py +++ b/unitTests.py @@ -850,7 +850,7 @@ class ParseKeywordTest(ParseTestCase): print_("Match Literal", end=' ')
try:
print_(lit.parseString(s))
- except:
+ except Exception:
print_("failed")
if litShouldPass:
self.assertTrue(False, "Literal failed to match %s, should have" % s)
@@ -861,7 +861,7 @@ class ParseKeywordTest(ParseTestCase): print_("Match Keyword", end=' ')
try:
print_(kw.parseString(s))
- except:
+ except Exception:
print_("failed")
if kwShouldPass:
self.assertTrue(False, "Keyword failed to match %s, should have" % s)
@@ -3939,10 +3939,10 @@ class MiscellaneousParserTests(ParseTestCase): print_(t, repr(t))
try:
names.append( t[0].getName() )
- except:
+ except Exception:
try:
names.append( t.getName() )
- except:
+ except Exception:
names.append( None )
print_(teststring)
print_(names)
|