diff options
| author | Jon Dufresne <jon.dufresne@gmail.com> | 2017-10-06 08:02:05 -0400 |
|---|---|---|
| committer | Jon Dufresne <jon.dufresne@gmail.com> | 2017-10-11 18:48:03 -0700 |
| commit | aea4d6a0dd052b3fa28e1b00c9922bf31326673c (patch) | |
| tree | ea256e7191cd9b5acb287d737bd701e43982e3d5 /src/saml2/algsupport.py | |
| parent | 847e970c5af6a09de61307be3a3d0305eee131f7 (diff) | |
| download | pysaml2-aea4d6a0dd052b3fa28e1b00c9922bf31326673c.tar.gz | |
Clean up unclosed files causing ResourceWarnings in tests
* Use better subprocess functions to correctly close pipes.
* When opening files, use a context manager to ensure file is closed
in a deterministic way.
* Close logging handlers
Diffstat (limited to 'src/saml2/algsupport.py')
| -rw-r--r-- | src/saml2/algsupport.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/saml2/algsupport.py b/src/saml2/algsupport.py index 72036b40..5134c039 100644 --- a/src/saml2/algsupport.py +++ b/src/saml2/algsupport.py @@ -36,10 +36,9 @@ SIGNING_METHODS = { def get_algorithm_support(xmlsec): com_list = [xmlsec, '--list-transforms'] pof = Popen(com_list, stderr=PIPE, stdout=PIPE) - - p_out = pof.stdout.read().decode('utf-8') - p_err = pof.stderr.read().decode('utf-8') - pof.wait() + p_out, p_err = pof.communicate() + p_out = p_out.decode('utf-8') + p_err = p_err.decode('utf-8') if not p_err: p = p_out.splitlines() |