Merge pull request #528 from c00kiemon5ter/fix-logout-return-addrs

Retrieve SLO endpoint by the appropriate service type

This is triggered when the self.config object has not been created through the SPConfig class, or the IdPConfig class, or the config_factory() function, but directly through the Config class. This results in the config object not having a context as it empty by default.

When that happens and endpoint() is called without being passed a context parameter, then getattr() will fail to return the correct attribute.

The solution is to pass the context parameter when calling the endpoint() method. This is achieved by passing the entity_type attribute.

Moreover, _parse_response() used to call endpoint() only for BINDING_HTTP_REDIRECT and BINDING_HTTP_POST. Thus, return_addrs would be left empty for BINDING_SOAP.

The second part of the solution is adding BINDING_SOAP to the bindings that will be checked to fill in return_addrs.

0 files changed, 0 insertions, 0 deletions