diff options
| author | Jozef Knaperek <jknaperek@gmail.com> | 2015-10-12 16:22:19 +0200 |
|---|---|---|
| committer | Jozef Knaperek <jknaperek@gmail.com> | 2015-10-15 15:33:10 +0200 |
| commit | c7febbf9e8c85355dccb53a326a51bfc41db1c66 (patch) | |
| tree | 976664df2088314a431be719f64359448ddf17e9 /src/saml2/ident.py | |
| parent | 1228db66eb006e0f069cc1b6b1612c6cbaa8df1d (diff) | |
| download | pysaml2-c7febbf9e8c85355dccb53a326a51bfc41db1c66.tar.gz | |
Fix paramter passing in logging messages
Pass parameters into logger calls directly instead of pre-merging
with the logger message. This way the logs are easier to maintain
and process. The code is also faster when logging is turned off
since it doesn't have to evaluate all params and render them into
strings.
Diffstat (limited to 'src/saml2/ident.py')
| -rw-r--r-- | src/saml2/ident.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/saml2/ident.py b/src/saml2/ident.py index 502f1315..b6af8e99 100644 --- a/src/saml2/ident.py +++ b/src/saml2/ident.py @@ -184,7 +184,7 @@ class IdentDB(object): try: _vals = self.db[userid] except KeyError: - logger.debug("failed to find userid %s in IdentDB" % userid) + logger.debug("failed to find userid %s in IdentDB", userid) return res for val in _vals.split(" "): @@ -211,8 +211,8 @@ class IdentDB(object): :return: """ - logger.debug("local_policy: %s, name_id_policy: %s" % (local_policy, - name_id_policy)) + logger.debug("local_policy: %s, name_id_policy: %s", local_policy, + name_id_policy) if name_id_policy and name_id_policy.sp_name_qualifier: sp_name_qualifier = name_id_policy.sp_name_qualifier @@ -280,8 +280,8 @@ class IdentDB(object): try: return self.db[name_id.text] except KeyError: - logger.debug("name: %s" % name_id.text) - #logger.debug("id sub keys: %s" % self.subkeys()) + logger.debug("name: %s", name_id.text) + #logger.debug("id sub keys: %s", self.subkeys()) return None def match_local_id(self, userid, sp_name_qualifier, name_qualifier): |