diff options
author | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-10 02:28:38 +0300 |
---|---|---|
committer | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-11 02:11:12 +0300 |
commit | bc96c3856dfd6ffbd27e0f59acacfef2b71e4edd (patch) | |
tree | 543f78595d25fd3127199e26917df9b3c67c156b /src/saml2/pack.py | |
parent | 7b1b52e03f06310bc23f688fe3f373881950a9f7 (diff) | |
download | pysaml2-assert_deletion.tar.gz |
Replace assert with proper checksassert_deletion
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Diffstat (limited to 'src/saml2/pack.py')
-rw-r--r-- | src/saml2/pack.py | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/saml2/pack.py b/src/saml2/pack.py index 5a2534c2..090b13b4 100644 --- a/src/saml2/pack.py +++ b/src/saml2/pack.py @@ -179,7 +179,10 @@ def http_redirect_message(message, location, relay_state="", typ="SAMLRequest", if signer: # sigalgs, should be one defined in xmldsig - assert sigalg in [b for a, b in SIG_ALLOWED_ALG] + if sigalg not in [long_name for short_name, long_name in SIG_ALLOWED_ALG]: + raise Exception( + "Signature algo not in allowed list: {algo}".format(algo=sigalg) + ) args["SigAlg"] = sigalg string = "&".join([urlencode({k: args[k]}) @@ -269,7 +272,14 @@ def parse_soap_enveloped_saml(text, body_class, header_class=None): :return: header parts and body as saml.samlbase instances """ envelope = defusedxml.ElementTree.fromstring(text) - assert envelope.tag == '{%s}Envelope' % NAMESPACE + + envelope_tag = "{%s}Envelope" % NAMESPACE + if envelope.tag != envelope_tag: + raise ValueError( + "Invalid envelope tag '{invalid}' should be '{valid}'".format( + invalid=envelope.tag, valid=envelope_tag + ) + ) # print(len(envelope)) body = None |