diff options
author | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-10 02:28:38 +0300 |
---|---|---|
committer | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-11 02:11:12 +0300 |
commit | bc96c3856dfd6ffbd27e0f59acacfef2b71e4edd (patch) | |
tree | 543f78595d25fd3127199e26917df9b3c67c156b /src/saml2/request.py | |
parent | 7b1b52e03f06310bc23f688fe3f373881950a9f7 (diff) | |
download | pysaml2-assert_deletion.tar.gz |
Replace assert with proper checksassert_deletion
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Diffstat (limited to 'src/saml2/request.py')
-rw-r--r-- | src/saml2/request.py | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/src/saml2/request.py b/src/saml2/request.py index 479b993f..20b711cf 100644 --- a/src/saml2/request.py +++ b/src/saml2/request.py @@ -80,15 +80,21 @@ class Request(object): return issued_at > lower and issued_at < upper def _verify(self): - assert self.message.version == "2.0" + valid_version = "2.0" + if self.message.version != valid_version: + raise VersionMismatch( + "Invalid version {invalid} should be {valid}".format( + invalid=self.message.version, valid=valid_version + ) + ) + if self.message.destination and self.receiver_addrs and \ self.message.destination not in self.receiver_addrs: - logger.error("%s not in %s", self.message.destination, - self.receiver_addrs) + logger.error("%s not in %s", self.message.destination, self.receiver_addrs) raise OtherError("Not destined for me!") - assert self.issue_instant_ok() - return self + valid = self.issue_instant_ok() + return valid def loads(self, xmldata, binding, origdoc=None, must=None, only_valid_cert=False): |