summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlya Etingof <etingof@gmail.com>2017-03-22 01:50:45 +0100
committerIlya Etingof <etingof@gmail.com>2017-03-22 01:50:45 +0100
commit3ca5bcc3cbe11d34a1f397f25b09a91a145f7ca5 (patch)
treed049f6e1666a497553bee898d0136d2f1de5d764
parent36feb0ea558304b3d741486a8e6ad3bc013eccf5 (diff)
downloadpysnmp-git-textual-convention-recursion-fix.tar.gz
fixed crash on unknown PDU reportingtextual-convention-recursion-fix
-rw-r--r--CHANGES.txt2
-rw-r--r--pysnmp/proto/rfc3412.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/CHANGES.txt b/CHANGES.txt
index c2d5ef35..80cba153 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -8,6 +8,8 @@ Revision 4.3.5, released 2017-0X-XX
SNMPv1 PDU
- Fix to possible infinite recursion in TextualConvention.prettyIn()
- TextualConvention is now a new-style class
+- Fixed crash when attempting to report unsupported request/notification
+ PDU back to sender
Revision 4.3.4, released 2017-03-01
-----------------------------------
diff --git a/pysnmp/proto/rfc3412.py b/pysnmp/proto/rfc3412.py
index d65019d3..97dca0ae 100644
--- a/pysnmp/proto/rfc3412.py
+++ b/pysnmp/proto/rfc3412.py
@@ -361,8 +361,6 @@ class MsgAndPduDispatcher(object):
debug.logger & debug.flagDsp and debug.logger('receiveMessage: unhandled PDU type')
- # XXX fails on unknown PDU
-
try:
(destTransportDomain,
destTransportAddress,
@@ -374,7 +372,7 @@ class MsgAndPduDispatcher(object):
statusInformation
)
- except error.StatusInformation:
+ except (error.StatusInformation, error.ProtocolError):
debug.logger & debug.flagDsp and debug.logger(
'receiveMessage: report failed, statusInformation %s' % sys.exc_info()[1])
return restOfWholeMsg