Uppercase global constants (#238)

This is a massive patch essentially upper-casing global/class attributes
that mean to be constants.

Some previously exposed constants have been preserved for compatibility
reasons (notably, in `hlapi`), though the rest might break user code relying
on pysnmp 4.

1 files changed, 8 insertions, 8 deletions

diff --git a/pysnmp/hlapi/v3arch/lcd.py b/pysnmp/hlapi/v3arch/lcd.py
index c56592e6..aefee634 100644
--- a/pysnmp/hlapi/v3arch/lcd.py
+++ b/pysnmp/hlapi/v3arch/lcd.py
@@ -79,22 +79,22 @@ class CommandGeneratorLcdConfigurator(AbstractLcdConfigurator):
             )
             cache['parm'][paramsKey] = paramsName, 1
 
-        if transportTarget.transportDomain in cache['tran']:
-            transport, useCount = cache['tran'][transportTarget.transportDomain]
+        if transportTarget.TRANSPORT_DOMAIN in cache['tran']:
+            transport, useCount = cache['tran'][transportTarget.TRANSPORT_DOMAIN]
             transportTarget.verifyDispatcherCompatibility(snmpEngine)
-            cache['tran'][transportTarget.transportDomain] = transport, useCount + 1
-        elif config.getTransport(snmpEngine, transportTarget.transportDomain):
+            cache['tran'][transportTarget.TRANSPORT_DOMAIN] = transport, useCount + 1
+        elif config.getTransport(snmpEngine, transportTarget.TRANSPORT_DOMAIN):
             transportTarget.verifyDispatcherCompatibility(snmpEngine)
         else:
             transport = transportTarget.openClientMode()
             config.addTransport(
                 snmpEngine,
-                transportTarget.transportDomain,
+                transportTarget.TRANSPORT_DOMAIN,
                 transport
             )
-            cache['tran'][transportTarget.transportDomain] = transport, 1
+            cache['tran'][transportTarget.TRANSPORT_DOMAIN] = transport, 1
 
-        transportKey = (paramsName, transportTarget.transportDomain,
+        transportKey = (paramsName, transportTarget.TRANSPORT_DOMAIN,
                         transportTarget.transportAddr,
                         transportTarget.timeout,
                         transportTarget.retries,
@@ -108,7 +108,7 @@ class CommandGeneratorLcdConfigurator(AbstractLcdConfigurator):
             addrName = 'a%s' % self.nextID()
             config.addTargetAddr(
                 snmpEngine, addrName,
-                transportTarget.transportDomain,
+                transportTarget.TRANSPORT_DOMAIN,
                 transportTarget.transportAddr,
                 paramsName,
                 transportTarget.timeout * 100,