Merged revisions 532430 by hand from

https://svn.apache.org/repos/asf/incubator/qpid/branches/trunk/qpid/cpp

------------------------------------------------------------------------
r532430 | aconway | 2007-04-25 14:06:14 -0400 (Wed, 25 Apr 2007) | 10 lines


 * qpid/CommonOptions.h:
  - Convenience classs/functions to use boost::program_options.
  - CommonOptions class for options common to client/broker.
 * qpid/broker/Broker.h:
  - Replaced broker::Configuration with class Broker::Options,
    derived from CommonOptions.
 * qpidd.cpp: Updated options handling.
 * qpid/Exception.h: Added strError function to get std::string from errno.

------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/M2@532787 13f79535-47bb-0310-9956-ffa450edef68

5 files changed, 52 insertions, 442 deletions

diff --git a/cpp/lib/broker/Broker.cpp b/cpp/lib/broker/Broker.cpp
index 6c0d7a3f3f..806127bf43 100644
--- a/cpp/lib/broker/Broker.cpp
+++ b/cpp/lib/broker/Broker.cpp
@@ -22,38 +22,63 @@
 #include <memory>
 #include <Broker.h>
 
-
 using namespace qpid::broker;
 using namespace qpid::sys;
 
-Broker::Broker(const Configuration& config) :
-    acceptor(Acceptor::create(config.getPort(),
-                              config.getConnectionBacklog(),
-                              config.getWorkerThreads(),
-                              config.isTrace())),
-    factory(config.getStore())
+Broker::Options::Options() :
+    workerThreads(5),
+    maxConnections(500),
+    connectionBacklog(10),
+    store(),
+    stagingThreshold(5000000)
+{}
+
+void Broker::Options::addTo(po::options_description& desc)
+{
+    using namespace po;
+    CommonOptions::addTo(desc);
+    desc.add_options()
+        ("worker-threads", optValue(workerThreads, "N"),
+         "Broker thread pool size")
+        ("max-connections", optValue(maxConnections, "N"),
+         "Maximum allowed connections")
+        ("connection-backlog", optValue(connectionBacklog, "N"),
+         "Connection backlog limit for server socket.")
+        ("staging-threshold", optValue(stagingThreshold, "N"),
+         "Messages over N bytes are staged to disk.")
+        ("store", optValue(store,"LIBNAME"),
+         "Name of message store shared library.");
+}
+
+
+Broker::Broker(const Options& config) :
+    acceptor(Acceptor::create(config.port,
+                              config.connectionBacklog,
+                              config.workerThreads,
+                              config.trace)),
+    factory(config.store)
 { }
 
 
 Broker::shared_ptr Broker::create(int16_t port) 
 {
-    Configuration config;
-    config.setPort(port);
+    Options config;
+    config.port=port;
     return create(config);
 }
 
-Broker::shared_ptr Broker::create(const Configuration& config) {
+Broker::shared_ptr Broker::create(const Options& config) {
     return Broker::shared_ptr(new Broker(config));
 }    
-        
+
 void Broker::run() {
     acceptor->run(&factory);
 }
 
 void Broker::shutdown() {
-    acceptor->shutdown();
+    if (acceptor)
+        acceptor->shutdown();
 }
 
 Broker::~Broker() { }
 
-const int16_t Broker::DEFAULT_PORT(5672);
diff --git a/cpp/lib/broker/Broker.h b/cpp/lib/broker/Broker.h
index 8ea1a57c27..8b54bd592b 100644
--- a/cpp/lib/broker/Broker.h
+++ b/cpp/lib/broker/Broker.h
@@ -22,7 +22,7 @@
  *
  */
 
-#include <Configuration.h>
+#include <CommonOptions.h>
 #include <SessionHandlerFactoryImpl.h>
 #include <sys/Runnable.h>
 #include <sys/Acceptor.h>
@@ -37,7 +37,15 @@ class Broker : public qpid::sys::Runnable,
                public qpid::SharedObject<Broker>
 {
   public:
-    static const int16_t DEFAULT_PORT;
+    struct Options : public CommonOptions {
+        Options();
+        void addTo(po::options_description&);
+        int workerThreads;
+        int maxConnections;
+        int connectionBacklog;
+        std::string store;      
+        long stagingThreshold;
+    };
             
     virtual ~Broker();
 
@@ -45,12 +53,12 @@ class Broker : public qpid::sys::Runnable,
      * Create a broker.
      * @param port Port to listen on or 0 to pick a port dynamically.
      */
-    static shared_ptr create(int16_t port = DEFAULT_PORT);
+    static shared_ptr create(int16_t port = Options::DEFAULT_PORT);
 
     /**
      * Create a broker using a Configuration.
      */
-    static shared_ptr create(const Configuration& config);
+    static shared_ptr create(const Options& config);
 
     /**
      * Return listening port. If called before bind this is
@@ -70,7 +78,8 @@ class Broker : public qpid::sys::Runnable,
     virtual void shutdown();
 
   private:
-    Broker(const Configuration& config); 
+    Broker(const Options& config);
+    Options config;
     qpid::sys::Acceptor::shared_ptr acceptor;
     SessionHandlerFactoryImpl factory;
 };
diff --git a/cpp/lib/broker/Configuration.cpp b/cpp/lib/broker/Configuration.cpp
deleted file mode 100644
index e83c359f2d..0000000000
--- a/cpp/lib/broker/Configuration.cpp
+++ /dev/null
@@ -1,252 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
- */
-#include <Configuration.h>
-#include <string.h>
-#include <config.h>
-
-using namespace qpid::broker;
-using namespace std;
-
-Configuration::Configuration() :
-    daemon('d', "daemon", "Run as system daemon, detached from terminal.", false),
-    trace('t', "trace", "Print incoming & outgoing frames to the console", false),
-    port('p', "port", "Set the port to listen on (default=5672)", 5672),
-    workerThreads("worker-threads", "Set the number of worker threads to use (default=5).", 5),
-    maxConnections("max-connections", "Set the maximum number of connections the broker can accept (default=500).", 500),
-    connectionBacklog("connection-backlog", "Set the connection backlog for the servers socket (default=10)", 10),
-    store('s', "store", "Set the message store module to use (default='' which implies no store)", ""),
-    stagingThreshold("staging-threshold", "Set the message size threshold above which messages will be written to disk as they arrive (default=5,000,000)", 5000000),
-    help("help", "Print usage information", false),
-    version("version", "Print version information", false)
-{
-    options.push_back(&daemon);
-    options.push_back(&trace);
-    options.push_back(&port);
-    options.push_back(&workerThreads);
-    options.push_back(&maxConnections);
-    options.push_back(&connectionBacklog);
-    options.push_back(&store);
-    options.push_back(&stagingThreshold);
-    options.push_back(&help);
-    options.push_back(&version);
-}
-
-Configuration::~Configuration(){}
-
-void Configuration::parse(char const *progName, int argc, char** argv){
-    programName = progName;
-    int position = 1;
-    while(position < argc){
-        bool matched(false);
-        for(op_iterator i = options.begin(); i < options.end() && !matched; i++){
-            matched = (*i)->parse(position, argv, argc);
-        }
-        if(!matched) {
-            throw BadOptionException(
-                std::string("Unrecognised option: ")+argv[position]);
-        }
-    }
-}
-
-void Configuration::usage(){
-    std::cout << "Usage: " << programName << " [OPTION]..." << std::endl
-	      << "Start the Qpid AMQP broker daemon." << std::endl << std::endl
-	      << "Options:" << std::endl;
-    for(op_iterator i = options.begin(); i < options.end(); i++){
-        (*i)->print(std::cout);
-    }
-
-    std::cout << std::endl << "Report bugs to <" << PACKAGE_BUGREPORT << ">."
-	      << std::endl;
-}
-
-bool Configuration::isHelp() const {
-    return help.getValue();
-}
-
-bool Configuration::isVersion() const {
-    return version.getValue();
-}
-
-bool Configuration::isDaemon() const {
-    return daemon.getValue();
-}
-
-bool Configuration::isTrace() const {
-    return trace.getValue();
-}
-
-int Configuration::getPort() const {
-    return port.getValue();
-}
-
-int Configuration::getWorkerThreads() const {
-    return workerThreads.getValue();
-}
-
-int Configuration::getMaxConnections() const {
-    return maxConnections.getValue();
-}
-
-int Configuration::getConnectionBacklog() const {
-    return connectionBacklog.getValue();
-}
-
-const std::string& Configuration::getStore() const {
-    return store.getValue();
-}
-
-long Configuration::getStagingThreshold() const {
-    return stagingThreshold.getValue();
-}
-
-
-Configuration::Option::Option(const char _flag, const string& _name, const string& _desc) :
-    flag(string("-") + _flag), name("--" +_name), desc(_desc) {}
-
-Configuration::Option::Option(const string& _name, const string& _desc) :
-    flag(""), name("--" + _name), desc(_desc) {}
-
-Configuration::Option::~Option(){}
-
-bool Configuration::Option::match(const string& arg){
-    return flag == arg || name == arg;
-}
-
-bool Configuration::Option::parse(int& i, char** argv, int argc){
-    const string arg(argv[i]);
-    if(match(arg)){
-        if(needsValue()){
-            if(++i < argc) setValue(argv[i]);
-            else throw ParseException("Argument " + arg + " requires a value!");
-        }else{
-            setValue("");
-        }
-        i++;
-        return true;
-    }else{
-        return false;
-    }
-}
-
-void Configuration::Option::print(ostream& out) const {
-    out << "  ";
-    if(flag.length() > 0){
-        out << flag << ", ";
-    } else {
-        out << "    ";
-    }
-    out << name;
-    if(needsValue()) out << " <value>";
-    out << std::endl;
-    out << "            " << desc << std::endl;
-}
-
-
-// String Option:
-
-Configuration::StringOption::StringOption(const char _flag, const string& _name, const string& _desc, const string _value) :
-    Option(_flag,_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::StringOption::StringOption(const string& _name, const string& _desc, const string _value) :
-    Option(_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::StringOption::~StringOption(){}
-
-const string& Configuration::StringOption::getValue() const {
-    return value;
-}
-
-bool Configuration::StringOption::needsValue() const {
-    return true;
-}
-
-void Configuration::StringOption::setValue(const std::string& _value){
-    value = _value;
-}
-
-// Int Option:
-
-Configuration::IntOption::IntOption(const char _flag, const string& _name, const string& _desc, const int _value) :
-    Option(_flag,_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::IntOption::IntOption(const string& _name, const string& _desc, const int _value) :
-    Option(_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::IntOption::~IntOption(){}
-
-int Configuration::IntOption::getValue() const {
-    return value;
-}
-
-bool Configuration::IntOption::needsValue() const {
-    return true;
-}
-
-void Configuration::IntOption::setValue(const std::string& _value){
-    value = atoi(_value.c_str());
-}
-
-// Long Option:
-
-Configuration::LongOption::LongOption(const char _flag, const string& _name, const string& _desc, const long _value) :
-    Option(_flag,_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::LongOption::LongOption(const string& _name, const string& _desc, const long _value) :
-    Option(_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::LongOption::~LongOption(){}
-
-long Configuration::LongOption::getValue() const {
-    return value;
-}
-
-bool Configuration::LongOption::needsValue() const {
-    return true;
-}
-
-void Configuration::LongOption::setValue(const std::string& _value){
-    value = atol(_value.c_str());
-}
-
-// Bool Option:
-
-Configuration::BoolOption::BoolOption(const char _flag, const string& _name, const string& _desc, const bool _value) :
-    Option(_flag,_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::BoolOption::BoolOption(const string& _name, const string& _desc, const bool _value) :
-    Option(_name,_desc), defaultValue(_value), value(_value) {}
-
-Configuration::BoolOption::~BoolOption(){}
-
-bool Configuration::BoolOption::getValue() const {
-    return value;
-}
-
-bool Configuration::BoolOption::needsValue() const {
-    return false;
-}
-
-void Configuration::BoolOption::setValue(const std::string& /*not required*/){
-    //BoolOptions have no value. The fact that the option is specified
-    //implies the value is true.
-    value = true;
-}
diff --git a/cpp/lib/broker/Configuration.h b/cpp/lib/broker/Configuration.h
deleted file mode 100644
index 15f2117f5e..0000000000
--- a/cpp/lib/broker/Configuration.h
+++ /dev/null
@@ -1,170 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- * 
- *   http://www.apache.org/licenses/LICENSE-2.0
- * 
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
- */
-#ifndef _Configuration_
-#define _Configuration_
-
-#include <cstdlib>
-#include <iostream>
-#include <vector>
-#include <Exception.h>
-
-namespace qpid {
-namespace broker {
-class Configuration{
-
-    class Option {
-        const std::string flag;
-        const std::string name;
-        const std::string desc;
-
-        bool match(const std::string& arg);
-
-      protected:
-        virtual bool needsValue() const = 0;
-        virtual void setValue(const std::string& value) = 0;
-
-      public:
-        Option(const char flag, const std::string& name, const std::string& desc);
-        Option(const std::string& name, const std::string& desc);
-        virtual ~Option();
-
-        bool parse(int& i, char** argv, int argc);
-        void print(std::ostream& out) const;
-    };
-
-    class IntOption : public Option{
-        const int defaultValue;
-        int value;
-      public:
-        IntOption(char flag, const std::string& name, const std::string& desc, const int value = 0);
-        IntOption(const std::string& name, const std::string& desc, const int value = 0);
-        virtual ~IntOption();
-
-        int getValue() const;
-        virtual bool needsValue() const;
-        virtual void setValue(const std::string& value);
-        virtual void setValue(int _value) { value = _value; }
-    };
-
-    class LongOption : public Option{
-        const long defaultValue;
-        int value;
-      public:
-        LongOption(char flag, const std::string& name, const std::string& desc, const long value = 0);
-        LongOption(const std::string& name, const std::string& desc, const long value = 0);
-        virtual ~LongOption();
-
-        long getValue() const;
-        virtual bool needsValue() const;
-        virtual void setValue(const std::string& value);
-        virtual void setValue(int _value) { value = _value; }
-    };
-
-    class StringOption : public Option{
-        const std::string defaultValue;
-        std::string value;
-      public:
-        StringOption(char flag, const std::string& name, const std::string& desc, const std::string value = "");
-        StringOption(const std::string& name, const std::string& desc, const std::string value = "");
-        virtual ~StringOption();
-
-        const std::string& getValue() const;
-        virtual bool needsValue() const;
-        virtual void setValue(const std::string& value);
-    };
-
-    class BoolOption : public Option{
-        const bool defaultValue;
-        bool value;
-      public:
-        BoolOption(char flag, const std::string& name, const std::string& desc, const bool value = 0);
-        BoolOption(const std::string& name, const std::string& desc, const bool value = 0);
-        virtual ~BoolOption();
-
-        bool getValue() const;
-        virtual bool needsValue() const;
-        virtual void setValue(const std::string& value);
-        virtual void setValue(bool _value) { value = _value; }
-    };
-
-    BoolOption daemon;
-    BoolOption trace;
-    IntOption port;
-    IntOption workerThreads;
-    IntOption maxConnections;
-    IntOption connectionBacklog;
-    StringOption store;
-    LongOption stagingThreshold;
-    BoolOption help;
-    BoolOption version;
-    char const *programName;
-
-    typedef std::vector<Option*>::iterator op_iterator;
-    std::vector<Option*> options;
-
-  public:
-
-    struct BadOptionException : public qpid::Exception {
-        BadOptionException(const std::string& msg)
-            : qpid::Exception(msg) {}
-    };
-            
-
-    class ParseException : public Exception {
-      public:
-        ParseException(const std::string& msg) : Exception(msg) {}
-    };
-
-
-    Configuration();
-    ~Configuration();
-
-    void parse(char const*, int argc, char** argv);
-
-    bool isHelp() const;
-    bool isVersion() const;
-    bool isDaemon() const;
-    bool isTrace() const;
-    int getPort() const;
-    int getWorkerThreads() const;
-    int getMaxConnections() const;
-    int getConnectionBacklog() const;
-    const std::string& getStore() const;
-    long getStagingThreshold() const;
-
-    void setHelp(bool b) { help.setValue(b); }
-    void setVersion(bool b) { version.setValue(b); }
-    void setDaemon(bool b) { daemon.setValue(b); }
-    void setTrace(bool b) { trace.setValue(b); }
-    void setPort(int i) { port.setValue(i); }
-    void setWorkerThreads(int i) { workerThreads.setValue(i); }
-    void setMaxConnections(int i) { maxConnections.setValue(i); }
-    void setConnectionBacklog(int i) { connectionBacklog.setValue(i); }
-    void setStore(const std::string& s) { store.setValue(s); }
-    void setStagingThreshold(long l) { stagingThreshold.setValue(l); }
-
-    void usage();
-};
-}
-}
-
-
-#endif
diff --git a/cpp/lib/broker/Makefile.am b/cpp/lib/broker/Makefile.am
index b093d13ea9..dfc0315902 100644
--- a/cpp/lib/broker/Makefile.am
+++ b/cpp/lib/broker/Makefile.am
@@ -24,8 +24,6 @@ libqpidbroker_la_SOURCES =			\
   BrokerMessage.h				\
   BrokerQueue.cpp				\
   BrokerQueue.h					\
-  Configuration.cpp				\
-  Configuration.h				\
   ConnectionToken.h				\
   Consumer.h					\
   Content.h					\