Improved/additional client API tests.

 - Replaced InProcessBroker with a more accurate loopback BrokerFixture.
 - Added asserts for mutex/condition/thread errors in debug build.
 - Added client tests for several exception conditions.
 - Added peer address to log ouput, client/server distinguished by (addr) or [addr]
 - Fixed various deadlocks & races exposed by the new  asserts & tests.


File-by-file:

New BrokerFixture replaces InProcessBroker
D      src/tests/InProcessBroker.h
M      src/tests/BrokerFixture.h
M      src/tests/SocketProxy.h
M      src/tests/Makefile.am

Made it run a bit faster.
M      src/tests/quick_perftest

Redundant
D      src/tests/APRBaseTest.cpp

Updated tests to use BrokerFixture
M      src/tests/ClientChannelTest.cpp
M      src/tests/exception_test.cpp
M      src/tests/ClientSessionTest.cpp

Print thread IDs in decimal, same as GDB.
M      src/qpid/log/Logger.cpp

Assert mutex/condition ops in debug build.
M      src/qpid/sys/posix/check.h
M      src/qpid/sys/posix/Mutex.h
M      src/qpid/sys/posix/Condition.h
M      src/qpid/sys/posix/Thread.h

Added toFd() so SocketProxy can use ::select()
M      src/qpid/sys/Socket.h
M      src/qpid/sys/posix/Socket.cpp

Fixes for races & deadlocks shown up by new tests & asserts.
Mostly shutdown/close issues.
M      src/qpid/client/ConnectionHandler.h
M      src/qpid/client/ConnectionImpl.cpp
M      src/qpid/client/Demux.h
M      src/qpid/client/SessionCore.cpp
M      src/qpid/client/ConnectionHandler.cpp
M      src/qpid/client/Connector.h
M      src/qpid/client/Demux.cpp
M      src/qpid/client/Dispatcher.cpp
M      src/qpid/client/ConnectionImpl.h

Logging peer address.
M      src/qpid/sys/AsynchIOAcceptor.cpp


git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@615063 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 8 insertions, 8 deletions

diff --git a/cpp/src/qpid/log/Options.cpp b/cpp/src/qpid/log/Options.cpp
index 41a15dcf9f..dd296f3a93 100644
--- a/cpp/src/qpid/log/Options.cpp
+++ b/cpp/src/qpid/log/Options.cpp
@@ -26,7 +26,7 @@ namespace log {
 using namespace std;
 
 Options::Options(const std::string& name) : qpid::Options(name),
-    time(true), level(true), thread(false), source(false), function(false), trace(false)
+                                            time(true), level(true), thread(false), source(false), function(false), trace(false)
 {
     outputs.push_back("stderr");
     selectors.push_back("error+");
@@ -43,14 +43,14 @@ Options::Options(const std::string& name) : qpid::Options(name),
         ("trace,t", optValue(trace), "Enables all logging" )
         ("log-enable", optValue(selectors, "RULE"),
          ("Enables logging for selected levels and components. " 
-         "RULE is in the form 'LEVEL[+][:PATTERN]' "
-         "Levels are one of: \n\t "+levels.str()+"\n"
-         "For example:\n"
-         "\t'--log-enable warning+' "
-         "logs all warning, error and critical messages.\n"
-         "\t'--log-enable debug:framing' "
+          "RULE is in the form 'LEVEL[+][:PATTERN]' "
+          "Levels are one of: \n\t "+levels.str()+"\n"
+          "For example:\n"
+          "\t'--log-enable warning+' "
+          "logs all warning, error and critical messages.\n"
+          "\t'--log-enable debug:framing' "
           "logs debug messages from the framing namespace. "
-         "This option can be used multiple times").c_str())
+          "This option can be used multiple times").c_str())
         ("log-time", optValue(time, "yes|no"),
          "Include time in log messages")
         ("log-level", optValue(level,"yes|no"),