diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2012-02-27 17:07:41 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2012-02-27 17:07:41 +0000 |
| commit | fa826fafd17b639452514d50949a34e0e990ca88 (patch) | |
| tree | cd764fb54089c7ec57674bf1eabf26ed7dc5781d /java | |
| parent | 00f86e6daf60ffb4d9e14ccc3cdfd5b327c879dd (diff) | |
| download | qpid-python-fa826fafd17b639452514d50949a34e0e990ca88.tar.gz | |
QPID-24 : [Java Broker] Fix potential leak of preparedstatement on exception in derby store
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1294230 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'java')
| -rw-r--r-- | java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java b/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java index 2cc9a5423e..4d63136a9d 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java +++ b/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java @@ -2251,11 +2251,12 @@ public class DerbyMessageStore implements MessageStore, DurableConfigurationStor PreparedStatement pstmt = conn.prepareStatement(SELECT_ALL_FROM_XID_ACTIONS); - pstmt.setLong(1, xid.getFormat()); - pstmt.setBytes(2, xid.getGlobalId()); - pstmt.setBytes(3, xid.getBranchId()); try { + pstmt.setLong(1, xid.getFormat()); + pstmt.setBytes(2, xid.getGlobalId()); + pstmt.setBytes(3, xid.getBranchId()); + ResultSet rs = pstmt.executeQuery(); try { |