diff options
-rw-r--r-- | cpp/examples/messaging/drain.cpp | 2 | ||||
-rw-r--r-- | cpp/examples/messaging/map_receiver.cpp | 2 | ||||
-rw-r--r-- | cpp/examples/messaging/queue_receiver.cpp | 4 | ||||
-rw-r--r-- | cpp/examples/messaging/topic_receiver.cpp | 4 | ||||
-rw-r--r-- | cpp/include/qpid/messaging/Receiver.h | 2 | ||||
-rw-r--r-- | cpp/include/qpid/messaging/Sender.h | 2 | ||||
-rw-r--r-- | cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp | 6 | ||||
-rw-r--r-- | cpp/src/qpid/client/amqp0_10/ReceiverImpl.h | 10 | ||||
-rw-r--r-- | cpp/src/qpid/client/amqp0_10/SenderImpl.cpp | 6 | ||||
-rw-r--r-- | cpp/src/qpid/client/amqp0_10/SenderImpl.h | 10 | ||||
-rw-r--r-- | cpp/src/qpid/client/amqp0_10/SessionImpl.cpp | 6 | ||||
-rw-r--r-- | cpp/src/qpid/messaging/Receiver.cpp | 2 | ||||
-rw-r--r-- | cpp/src/qpid/messaging/ReceiverImpl.h | 2 | ||||
-rw-r--r-- | cpp/src/qpid/messaging/Sender.cpp | 2 | ||||
-rw-r--r-- | cpp/src/qpid/messaging/SenderImpl.h | 2 | ||||
-rw-r--r-- | cpp/src/tests/MessagingSessionTests.cpp | 36 |
16 files changed, 49 insertions, 49 deletions
diff --git a/cpp/examples/messaging/drain.cpp b/cpp/examples/messaging/drain.cpp index 2bd9fcdac8..3834aa3dfd 100644 --- a/cpp/examples/messaging/drain.cpp +++ b/cpp/examples/messaging/drain.cpp @@ -111,7 +111,7 @@ int main(int argc, char** argv) std::cout << "')" << std::endl; session.acknowledge(); } - receiver.cancel(); + receiver.close(); session.close(); connection.close(); return 0; diff --git a/cpp/examples/messaging/map_receiver.cpp b/cpp/examples/messaging/map_receiver.cpp index f97c44eebd..0106ce878c 100644 --- a/cpp/examples/messaging/map_receiver.cpp +++ b/cpp/examples/messaging/map_receiver.cpp @@ -46,7 +46,7 @@ int main(int argc, char** argv) { MapView content(message); std::cout << content << std::endl; session.acknowledge(); - receiver.cancel(); + receiver.close(); connection.close(); return 0; } catch(const std::exception& error) { diff --git a/cpp/examples/messaging/queue_receiver.cpp b/cpp/examples/messaging/queue_receiver.cpp index 40f863eb30..058a4e19ae 100644 --- a/cpp/examples/messaging/queue_receiver.cpp +++ b/cpp/examples/messaging/queue_receiver.cpp @@ -42,8 +42,8 @@ int main(int argc, char** argv) { std::cout << "Message: " << message.getContent() << std::endl; session.acknowledge(); if (message.getContent() == "That's all, folks!") { - std::cout << "Cancelling receiver" << std::endl; - receiver.cancel(); + std::cout << "Closing receiver" << std::endl; + receiver.close(); break; } } diff --git a/cpp/examples/messaging/topic_receiver.cpp b/cpp/examples/messaging/topic_receiver.cpp index 45ab9448db..321231f93d 100644 --- a/cpp/examples/messaging/topic_receiver.cpp +++ b/cpp/examples/messaging/topic_receiver.cpp @@ -42,8 +42,8 @@ int main(int argc, char** argv) { Message message = receiver.fetch(); std::cout << "Message: " << message.getContent() << std::endl; if (message.getContent() == "That's all, folks!") { - std::cout << "Cancelling receiver" << std::endl; - receiver.cancel(); + std::cout << "Closing receiver" << std::endl; + receiver.close(); break; } } diff --git a/cpp/include/qpid/messaging/Receiver.h b/cpp/include/qpid/messaging/Receiver.h index 51630b12a2..0923178065 100644 --- a/cpp/include/qpid/messaging/Receiver.h +++ b/cpp/include/qpid/messaging/Receiver.h @@ -110,7 +110,7 @@ class Receiver : public qpid::client::Handle<ReceiverImpl> /** * Cancels this receiver. */ - QPID_CLIENT_EXTERN void cancel(); + QPID_CLIENT_EXTERN void close(); /** * Returns the name of this receiver. diff --git a/cpp/include/qpid/messaging/Sender.h b/cpp/include/qpid/messaging/Sender.h index 335e61260c..eb8ccc2f84 100644 --- a/cpp/include/qpid/messaging/Sender.h +++ b/cpp/include/qpid/messaging/Sender.h @@ -50,7 +50,7 @@ class Sender : public qpid::client::Handle<SenderImpl> QPID_CLIENT_EXTERN Sender& operator=(const Sender&); QPID_CLIENT_EXTERN void send(const Message& message); - QPID_CLIENT_EXTERN void cancel(); + QPID_CLIENT_EXTERN void close(); /** * Sets the capacity for the sender. The capacity determines how diff --git a/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp b/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp index bc5c53fde6..1f5c3162e5 100644 --- a/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp +++ b/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp @@ -68,9 +68,9 @@ bool ReceiverImpl::fetch(qpid::messaging::Message& message, qpid::sys::Duration return f.result; } -void ReceiverImpl::cancel() +void ReceiverImpl::close() { - execute<Cancel>(); + execute<Close>(); } void ReceiverImpl::start() @@ -167,7 +167,7 @@ bool ReceiverImpl::fetchImpl(qpid::messaging::Message& message, qpid::sys::Durat } } -void ReceiverImpl::cancelImpl() +void ReceiverImpl::closeImpl() { if (state != CANCELLED) { state = CANCELLED; diff --git a/cpp/src/qpid/client/amqp0_10/ReceiverImpl.h b/cpp/src/qpid/client/amqp0_10/ReceiverImpl.h index d40aac4058..0dcca3ac07 100644 --- a/cpp/src/qpid/client/amqp0_10/ReceiverImpl.h +++ b/cpp/src/qpid/client/amqp0_10/ReceiverImpl.h @@ -54,7 +54,7 @@ class ReceiverImpl : public qpid::messaging::ReceiverImpl qpid::messaging::Message get(qpid::sys::Duration timeout); bool fetch(qpid::messaging::Message& message, qpid::sys::Duration timeout); qpid::messaging::Message fetch(qpid::sys::Duration timeout); - void cancel(); + void close(); void start(); void stop(); const std::string& getName() const; @@ -81,7 +81,7 @@ class ReceiverImpl : public qpid::messaging::ReceiverImpl //implementation of public facing methods bool fetchImpl(qpid::messaging::Message& message, qpid::sys::Duration timeout); bool getImpl(qpid::messaging::Message& message, qpid::sys::Duration timeout); - void cancelImpl(); + void closeImpl(); void setCapacityImpl(uint32_t); //functors for public facing methods (allows locking and retry @@ -115,10 +115,10 @@ class ReceiverImpl : public qpid::messaging::ReceiverImpl void operator()() { result = impl.fetchImpl(message, timeout); } }; - struct Cancel : Command + struct Close : Command { - Cancel(ReceiverImpl& i) : Command(i) {} - void operator()() { impl.cancelImpl(); } + Close(ReceiverImpl& i) : Command(i) {} + void operator()() { impl.closeImpl(); } }; struct SetCapacity : Command diff --git a/cpp/src/qpid/client/amqp0_10/SenderImpl.cpp b/cpp/src/qpid/client/amqp0_10/SenderImpl.cpp index 4d6b9869e6..b8dd299571 100644 --- a/cpp/src/qpid/client/amqp0_10/SenderImpl.cpp +++ b/cpp/src/qpid/client/amqp0_10/SenderImpl.cpp @@ -40,9 +40,9 @@ void SenderImpl::send(const qpid::messaging::Message& message) while (f.repeat) parent.execute(f); } -void SenderImpl::cancel() +void SenderImpl::close() { - execute<Cancel>(); + execute<Close>(); } void SenderImpl::setCapacity(uint32_t c) @@ -124,7 +124,7 @@ uint32_t SenderImpl::checkPendingSends(bool flush) return outgoing.size(); } -void SenderImpl::cancelImpl() +void SenderImpl::closeImpl() { state = CANCELLED; sink->cancel(session, name); diff --git a/cpp/src/qpid/client/amqp0_10/SenderImpl.h b/cpp/src/qpid/client/amqp0_10/SenderImpl.h index 80d9843d9e..881f3c754c 100644 --- a/cpp/src/qpid/client/amqp0_10/SenderImpl.h +++ b/cpp/src/qpid/client/amqp0_10/SenderImpl.h @@ -49,7 +49,7 @@ class SenderImpl : public qpid::messaging::SenderImpl SenderImpl(SessionImpl& parent, const std::string& name, const qpid::messaging::Address& address); void send(const qpid::messaging::Message&); - void cancel(); + void close(); void setCapacity(uint32_t); uint32_t getCapacity(); uint32_t pending(); @@ -80,7 +80,7 @@ class SenderImpl : public qpid::messaging::SenderImpl //logic for application visible methods: void sendImpl(const qpid::messaging::Message&); - void cancelImpl(); + void closeImpl(); //functors for application visible methods (allowing locking and @@ -108,10 +108,10 @@ class SenderImpl : public qpid::messaging::SenderImpl } }; - struct Cancel : Command + struct Close : Command { - Cancel(SenderImpl& i) : Command(i) {} - void operator()() { impl.cancelImpl(); } + Close(SenderImpl& i) : Command(i) {} + void operator()() { impl.closeImpl(); } }; struct CheckPendingSends : Command diff --git a/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp b/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp index 1343305174..62af6394b0 100644 --- a/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp +++ b/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp @@ -94,7 +94,7 @@ void SessionImpl::reject(qpid::messaging::Message& m) void SessionImpl::close() { - //cancel all the senders and receivers (get copy of names and then + //close all the senders and receivers (get copy of names and then //make the calls to avoid modifying maps while iterating over //them): std::vector<std::string> s; @@ -104,8 +104,8 @@ void SessionImpl::close() for (Senders::const_iterator i = senders.begin(); i != senders.end(); ++i) s.push_back(i->first); for (Receivers::const_iterator i = receivers.begin(); i != receivers.end(); ++i) r.push_back(i->first); } - for (std::vector<std::string>::const_iterator i = s.begin(); i != s.end(); ++i) getSender(*i).cancel(); - for (std::vector<std::string>::const_iterator i = r.begin(); i != r.end(); ++i) getReceiver(*i).cancel(); + for (std::vector<std::string>::const_iterator i = s.begin(); i != s.end(); ++i) getSender(*i).close(); + for (std::vector<std::string>::const_iterator i = r.begin(); i != r.end(); ++i) getReceiver(*i).close(); connection.closed(*this); diff --git a/cpp/src/qpid/messaging/Receiver.cpp b/cpp/src/qpid/messaging/Receiver.cpp index bf9c056db8..478228e0fb 100644 --- a/cpp/src/qpid/messaging/Receiver.cpp +++ b/cpp/src/qpid/messaging/Receiver.cpp @@ -47,7 +47,7 @@ void Receiver::setCapacity(uint32_t c) { impl->setCapacity(c); } uint32_t Receiver::getCapacity() { return impl->getCapacity(); } uint32_t Receiver::available() { return impl->available(); } uint32_t Receiver::pendingAck() { return impl->pendingAck(); } -void Receiver::cancel() { impl->cancel(); } +void Receiver::close() { impl->close(); } const std::string& Receiver::getName() const { return impl->getName(); } Session Receiver::getSession() const { return impl->getSession(); } }} // namespace qpid::messaging diff --git a/cpp/src/qpid/messaging/ReceiverImpl.h b/cpp/src/qpid/messaging/ReceiverImpl.h index 447a505518..2076de5d56 100644 --- a/cpp/src/qpid/messaging/ReceiverImpl.h +++ b/cpp/src/qpid/messaging/ReceiverImpl.h @@ -46,7 +46,7 @@ class ReceiverImpl : public virtual qpid::RefCounted virtual uint32_t getCapacity() = 0; virtual uint32_t available() = 0; virtual uint32_t pendingAck() = 0; - virtual void cancel() = 0; + virtual void close() = 0; virtual const std::string& getName() const = 0; virtual Session getSession() const = 0; }; diff --git a/cpp/src/qpid/messaging/Sender.cpp b/cpp/src/qpid/messaging/Sender.cpp index f2303f4126..5e18db1d7c 100644 --- a/cpp/src/qpid/messaging/Sender.cpp +++ b/cpp/src/qpid/messaging/Sender.cpp @@ -40,7 +40,7 @@ Sender::Sender(const Sender& s) : qpid::client::Handle<SenderImpl>() { PI::copy( Sender::~Sender() { PI::dtor(*this); } Sender& Sender::operator=(const Sender& s) { return PI::assign(*this, s); } void Sender::send(const Message& message) { impl->send(message); } -void Sender::cancel() { impl->cancel(); } +void Sender::close() { impl->close(); } void Sender::setCapacity(uint32_t c) { impl->setCapacity(c); } uint32_t Sender::getCapacity() { return impl->getCapacity(); } uint32_t Sender::pending() { return impl->pending(); } diff --git a/cpp/src/qpid/messaging/SenderImpl.h b/cpp/src/qpid/messaging/SenderImpl.h index 5f30417f6a..0294688771 100644 --- a/cpp/src/qpid/messaging/SenderImpl.h +++ b/cpp/src/qpid/messaging/SenderImpl.h @@ -37,7 +37,7 @@ class SenderImpl : public virtual qpid::RefCounted public: virtual ~SenderImpl() {} virtual void send(const Message& message) = 0; - virtual void cancel() = 0; + virtual void close() = 0; virtual void setCapacity(uint32_t) = 0; virtual uint32_t getCapacity() = 0; virtual uint32_t pending() = 0; diff --git a/cpp/src/tests/MessagingSessionTests.cpp b/cpp/src/tests/MessagingSessionTests.cpp index d48512e0df..91dad8f3f2 100644 --- a/cpp/src/tests/MessagingSessionTests.cpp +++ b/cpp/src/tests/MessagingSessionTests.cpp @@ -123,8 +123,8 @@ struct MessagingFixture : public BrokerFixture Message in; BOOST_CHECK(r.fetch(in, 5*qpid::sys::TIME_SEC)); BOOST_CHECK_EQUAL(out.getContent(), in.getContent()); - r.cancel(); - s.cancel(); + r.close(); + s.close(); } ~MessagingFixture() @@ -284,7 +284,7 @@ QPID_AUTO_TEST_CASE(testSimpleTopic) msg.setContent("four"); sender.send(msg); BOOST_CHECK_EQUAL(fetch(sub2, 2), boost::assign::list_of<std::string>("three")("four")); - sub2.cancel(); + sub2.close(); msg.setContent("five"); sender.send(msg); @@ -501,7 +501,7 @@ QPID_AUTO_TEST_CASE(testCreatePolicyQueueReceiver) QueueCreatePolicyFixture fix("#; {create:receiver, node-properties:{type:queue}}"); Receiver r = fix.session.createReceiver(fix.address); fix.test(); - r.cancel(); + r.close(); } QPID_AUTO_TEST_CASE(testCreatePolicyQueueSender) @@ -509,7 +509,7 @@ QPID_AUTO_TEST_CASE(testCreatePolicyQueueSender) QueueCreatePolicyFixture fix("#; {create:sender, node-properties:{type:queue}}"); Sender s = fix.session.createSender(fix.address); fix.test(); - s.cancel(); + s.close(); } struct ExchangeCreatePolicyFixture : public MessagingFixture @@ -546,7 +546,7 @@ QPID_AUTO_TEST_CASE(testCreatePolicyTopicReceiverFanout) ExchangeCreatePolicyFixture fix("#/my-subject; {create:receiver, node-properties:{type:topic, x-properties:{type:fanout}}}", "fanout"); Receiver r = fix.session.createReceiver(fix.address); fix.test(); - r.cancel(); + r.close(); } QPID_AUTO_TEST_CASE(testCreatePolicyTopicSenderDirect) @@ -554,7 +554,7 @@ QPID_AUTO_TEST_CASE(testCreatePolicyTopicSenderDirect) ExchangeCreatePolicyFixture fix("#/my-subject; {create:sender, node-properties:{type:topic, x-properties:{type:direct}}}", "direct"); Sender s = fix.session.createSender(fix.address); fix.test(); - s.cancel(); + s.close(); } struct DeletePolicyFixture : public MessagingFixture @@ -598,25 +598,25 @@ struct DeletePolicyFixture : public MessagingFixture Receiver r = session.createReceiver(address); switch (mode) { case RECEIVER: - s.cancel(); + s.close(); BOOST_CHECK(exists(address)); - r.cancel(); + r.close(); BOOST_CHECK(!exists(address)); break; case SENDER: - r.cancel(); + r.close(); BOOST_CHECK(exists(address)); - s.cancel(); + s.close(); BOOST_CHECK(!exists(address)); break; case ALWAYS: - s.cancel(); + s.close(); BOOST_CHECK(!exists(address)); break; case NEVER: - r.cancel(); + r.close(); BOOST_CHECK(exists(address)); - s.cancel(); + s.close(); BOOST_CHECK(exists(address)); destroy(address); } @@ -676,19 +676,19 @@ QPID_AUTO_TEST_CASE(testAssertPolicyQueue) MessagingFixture fix; std::string a1 = "q; {create:always, assert:always, node-properties:{type:queue, durable:false, x-properties:{qpid.max-count:100}}}"; Sender s1 = fix.session.createSender(a1); - s1.cancel(); + s1.close(); Receiver r1 = fix.session.createReceiver(a1); - r1.cancel(); + r1.close(); std::string a2 = "q; {assert:receiver, node-properties:{durable:true, x-properties:{qpid.max-count:100}}}"; Sender s2 = fix.session.createSender(a2); - s2.cancel(); + s2.close(); BOOST_CHECK_THROW(fix.session.createReceiver(a2), qpid::messaging::InvalidAddress); std::string a3 = "q; {assert:sender, node-properties:{x-properties:{qpid.max-count:99}}}"; BOOST_CHECK_THROW(fix.session.createSender(a3), qpid::messaging::InvalidAddress); Receiver r3 = fix.session.createReceiver(a3); - r3.cancel(); + r3.close(); fix.admin.deleteQueue("q"); } |